diff options
| author | Gowrishankar Muthukrishnan <gmuthukr@redhat.com> | 2019-10-21 19:34:36 +0530 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2019-10-30 10:50:27 -0700 |
| commit | a773a5c90c7821d2bbb91badd8c5c428a6150b45 (patch) | |
| tree | de12f76c7c7a57ffacdd9a03c896773172b5593a /ofproto | |
| parent | 7139ca5521abbb23fee0cd356ec580b01d3e563a (diff) | |
| download | openvswitch-a773a5c90c7821d2bbb91badd8c5c428a6150b45.tar.gz | |
lacp: warn transmit failure of lacp pdu
It might be difficult to trace whether LACP PDU tx (as in
response) was successful when the pdu was not transmitted by
egress slave for various reasons (including resource contention
within NIC) and only way to trace its fate is by looking at
ofproto->stats.tx_[packets/bytes] and slave port stats.
Adding a warning when there is tx failure could help user
debug at the root of this problem.
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr@redhat.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'ofproto')
| -rw-r--r-- | ofproto/ofproto-dpif.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index ab5f48794..c35ec3e61 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -3405,7 +3405,11 @@ send_pdu_cb(void *port_, const void *pdu, size_t pdu_size) pdu_size); memcpy(packet_pdu, pdu, pdu_size); - ofproto_dpif_send_packet(port, false, &packet); + error = ofproto_dpif_send_packet(port, false, &packet); + if (error) { + VLOG_WARN_RL(&rl, "port %s: cannot transmit LACP PDU (%s).", + port->bundle->name, ovs_strerror(error)); + } dp_packet_uninit(&packet); } else { static struct vlog_rate_limit rll = VLOG_RATE_LIMIT_INIT(1, 10); |