diff options
| author | Ben Pfaff <blp@ovn.org> | 2017-08-02 08:36:07 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2017-08-02 15:03:31 -0700 |
| commit | b24fa3f486d4061cb9facd181fd6234f281904df (patch) | |
| tree | 3f97ad4d9c239d7882c87e9fbb9f3d4b7d0ab1c7 /ofproto | |
| parent | f3eb7691bfddda35dc65c781de54adf837e8f6b7 (diff) | |
| download | openvswitch-b24fa3f486d4061cb9facd181fd6234f281904df.tar.gz | |
ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.
This inner 'xcfg' shadowed the outer one and could have read a different
value if 'xcfgp' was changing, so this is possibly a bug fix.
Found by -Wshadow=local in GCC 7.
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Andy Zhou <azhou@ovn.org>
Diffstat (limited to 'ofproto')
| -rw-r--r-- | ofproto/ofproto-dpif-xlate.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index a2f5dc7df..023dc82a3 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -6679,7 +6679,6 @@ xlate_actions(struct xlate_in *xin, struct xlate_out *xout) /* Set the bridge for post-recirculation processing if needed. */ if (!uuid_equals(&ctx.xbridge->ofproto->uuid, &state->ofproto_uuid)) { - struct xlate_cfg *xcfg = ovsrcu_get(struct xlate_cfg *, &xcfgp); const struct xbridge *new_bridge = xbridge_lookup_by_uuid(xcfg, &state->ofproto_uuid); |