diff options
| author | Darrell Ball <dlu998@gmail.com> | 2018-04-24 02:35:40 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2018-05-09 14:21:28 -0700 |
| commit | d261aefd1dfc689fa8a3411aea0facbbaa1186da (patch) | |
| tree | 1d683433860ed0e769b59bbb555d2f66f5ada3b5 /ovn/northd/ovn-northd.c | |
| parent | 28533680540b7ed7fbbce73ec67abcd4b68ad8a4 (diff) | |
| download | openvswitch-d261aefd1dfc689fa8a3411aea0facbbaa1186da.tar.gz | |
ovn-northd: Fix parsing of load balance keys.
The OVN load balance tests are failing in both kernel and userspace DP.
The problem is due to bad parsing of the load balance keys because of
using the wrong default port mode in the call to inet_parse_active().
With this fix, the tests are now passing again.
system-ovn
100: ovn -- load-balancing ok
101: ovn -- load-balancing - same subnet. ok
102: ovn -- load balancing in gateway router ok
103: ovn -- multiple gateway routers, load-balancing ok
104: ovn -- load balancing in router with gateway router port ok
Signed-off-by: Darrell Ball <dlu998@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Mark Michelson <mmichels@redhat.com>
Diffstat (limited to 'ovn/northd/ovn-northd.c')
| -rw-r--r-- | ovn/northd/ovn-northd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index cd01756a0..cef4d978f 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -2942,7 +2942,7 @@ ip_address_and_port_from_lb_key(const char *key, char **ip_address, uint16_t *port, int *addr_family) { struct sockaddr_storage ss; - if (!inet_parse_active(key, -1, &ss)) { + if (!inet_parse_active(key, 0, &ss)) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); VLOG_WARN_RL(&rl, "bad ip address or port for load balancer key %s", key); |