summaryrefslogtreecommitdiff
path: root/ovn
diff options
context:
space:
mode:
authorBen Pfaff <blp@ovn.org>2017-01-13 11:30:07 -0800
committerBen Pfaff <blp@ovn.org>2017-02-02 09:48:16 -0800
commit0a8dda70d47957fd9552963c8857d876c281f749 (patch)
tree39e54b43bfe601a29c202d9a2cb76a128ae10d3c /ovn
parentc37f71352dfbf466ae8e07891c7394dd13c7cd5b (diff)
downloadopenvswitch-0a8dda70d47957fd9552963c8857d876c281f749.tar.gz
ovn-trace: Style improvements.
Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Russell Bryant <russell@ovn.org>
Diffstat (limited to 'ovn')
-rw-r--r--ovn/utilities/ovn-trace.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c
index e9d4a71d2..66844b11a 100644
--- a/ovn/utilities/ovn-trace.c
+++ b/ovn/utilities/ovn-trace.c
@@ -872,13 +872,17 @@ ovntrace_stage_name(const struct ovntrace_datapath *dp,
return NULL;
}
+/* Type of a node within a trace. */
enum ovntrace_node_type {
+ /* Nodes that may have children (nonterminal nodes). */
OVNTRACE_NODE_OUTPUT,
OVNTRACE_NODE_MODIFY,
- OVNTRACE_NODE_PIPELINE,
- OVNTRACE_NODE_TABLE,
OVNTRACE_NODE_ACTION,
OVNTRACE_NODE_ERROR,
+
+ /* Nodes that never have children (terminal nodes). */
+ OVNTRACE_NODE_PIPELINE,
+ OVNTRACE_NODE_TABLE,
OVNTRACE_NODE_TRANSFORMATION
};
@@ -976,7 +980,9 @@ ovntrace_node_print_details(struct ds *output,
continue;
}
- bool more = sub->node.next != nodes || sub->always_indent || ovntrace_node_type_is_terminal(sub->type);
+ bool more = (sub->node.next != nodes
+ || sub->always_indent
+ || ovntrace_node_type_is_terminal(sub->type));
bool title = (sub->type == OVNTRACE_NODE_PIPELINE ||
sub->type == OVNTRACE_NODE_TRANSFORMATION);
if (title) {