diff options
| author | Yifeng Sun <pkusunyifeng@gmail.com> | 2017-11-15 06:59:26 -0800 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2017-11-29 14:16:44 -0800 |
| commit | 6a07ccaadb38ffbcf8a309d92df48e5587900c39 (patch) | |
| tree | 26ff158cde5535dd6d723d511aaa648b4a1e91d4 /ovn | |
| parent | 962044bf24df87f611f74d06c5c4d7b5ba411dfd (diff) | |
| download | openvswitch-6a07ccaadb38ffbcf8a309d92df48e5587900c39.tar.gz | |
bfd: Fix memory leak
Valgrind complains in test 2359 ():
864 (576 direct, 288 indirect) bytes in 18 blocks are definitely
lost in loss record 96 of 101
by 0x4A6D64: xmalloc (util.c:120)
by 0x40BC04: gateway_chassis_get_ordered (gchassis.c:73)
by 0x408CF0: bfd_calculate_chassis (bfd.c:219)
by 0x408CF0: bfd_run (bfd.c:257)
by 0x407F72: main (ovn-controller.c:718)
gateway_chassis wasn't released before the 'continue' line.
Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Tested-by: Greg Rose <gvrose8192@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Diffstat (limited to 'ovn')
| -rw-r--r-- | ovn/controller/bfd.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ovn/controller/bfd.c b/ovn/controller/bfd.c index efc1482ec..8f020d597 100644 --- a/ovn/controller/bfd.c +++ b/ovn/controller/bfd.c @@ -221,6 +221,7 @@ bfd_calculate_chassis(struct controller_ctx *ctx, /* we don't need BFD for non-HA chassisredirect */ if (!gateway_chassis || ovs_list_is_short(gateway_chassis)) { + gateway_chassis_destroy(gateway_chassis); continue; } our_chassis_is_gw_for_dp = gateway_chassis_contains( |