diff options
| author | Justin Pettit <jpettit@ovn.org> | 2016-07-06 16:27:57 -0700 |
|---|---|---|
| committer | Justin Pettit <jpettit@ovn.org> | 2016-07-19 21:54:54 -0700 |
| commit | fa7f915c630529616d038c964f251b1d97d6eca9 (patch) | |
| tree | 8200b82dddae3171c8eb5ed49a782bfb6d7db3c6 /ovn | |
| parent | 29d5e9a78332a0b9992cf4025788a5b2eec4a434 (diff) | |
| download | openvswitch-fa7f915c630529616d038c964f251b1d97d6eca9.tar.gz | |
packets: Define RSO flags.
Use #define's as opposed to magic numbers.
Signed-off-by: Justin Pettit <jpettit@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'ovn')
| -rw-r--r-- | ovn/controller/pinctrl.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/ovn/controller/pinctrl.c b/ovn/controller/pinctrl.c index 634271942..62f4748c3 100644 --- a/ovn/controller/pinctrl.c +++ b/ovn/controller/pinctrl.c @@ -969,11 +969,14 @@ pinctrl_handle_na(const struct flow *ip_flow, memcpy(ipv6_dst, &ip_flow->ipv6_src, sizeof ipv6_src); memcpy(ipv6_src, &ip_flow->nd_target, sizeof ipv6_dst); - /* Frame the NA packet with RSO=011. */ + /* xxx These flags are not exactly correct. Look at section 7.2.4 + * xxx of RFC 4861. For example, we need to set ND_RSO_ROUTER for + * xxx router's interfaces and ND_RSO_SOLICITED only if it was + * xxx requested. */ compose_na(&packet, ip_flow->dl_dst, ip_flow->dl_src, ipv6_src, ipv6_dst, - htonl(0x60000000)); + htonl(ND_RSO_SOLICITED | ND_RSO_OVERRIDE)); /* Reload previous packet metadata. */ uint64_t ofpacts_stub[4096 / 8]; |