diff options
author | Ben Pfaff <blp@ovn.org> | 2018-05-24 10:32:59 -0700 |
---|---|---|
committer | Ben Pfaff <blp@ovn.org> | 2018-05-25 13:36:05 -0700 |
commit | fa37affad362df15fc59db00aa96ee79cd5eebd9 (patch) | |
tree | f539cdab21f0951aa8bb7c8b6984d9854d33112d /ovsdb/column.c | |
parent | 3d62892884d88cf1d0d02f58b3317e6ec0ca8971 (diff) | |
download | openvswitch-fa37affad362df15fc59db00aa96ee79cd5eebd9.tar.gz |
Embrace anonymous unions.
Several OVS structs contain embedded named unions, like this:
struct {
...
union {
...
} u;
};
C11 standardized a feature that many compilers already implemented
anyway, where an embedded union may be unnamed, like this:
struct {
...
union {
...
};
};
This is more convenient because it allows the programmer to omit "u."
in many places. OVS already used this feature in several places. This
commit embraces it in several others.
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Justin Pettit <jpettit@ovn.org>
Tested-by: Alin Gabriel Serdean <aserdean@ovn.org>
Acked-by: Alin Gabriel Serdean <aserdean@ovn.org>
Diffstat (limited to 'ovsdb/column.c')
-rw-r--r-- | ovsdb/column.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ovsdb/column.c b/ovsdb/column.c index 8838df3eb..9dfc8714f 100644 --- a/ovsdb/column.c +++ b/ovsdb/column.c @@ -165,15 +165,15 @@ ovsdb_column_set_from_json(const struct json *json, } /* XXX this is O(n**2) */ - for (i = 0; i < json->u.array.n; i++) { + for (i = 0; i < json->array.n; i++) { const struct ovsdb_column *column; const char *s; - if (json->u.array.elems[i]->type != JSON_STRING) { + if (json->array.elems[i]->type != JSON_STRING) { goto error; } - s = json->u.array.elems[i]->u.string; + s = json->array.elems[i]->string; column = shash_find_data(&schema->columns, s); if (!column) { error = ovsdb_syntax_error(json, NULL, "%s is not a valid " |