diff options
| author | Ben Pfaff <blp@nicira.com> | 2012-03-28 14:13:02 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2012-03-28 14:55:27 -0700 |
| commit | 6e492d81450217a5c90cbb4ad31d81b1e611989b (patch) | |
| tree | 6882ef2d7c93c6887a8fcc48dbed3a7b55084b95 /ovsdb/row.h | |
| parent | 94c336723ca2228cfd60d2207775871e4b773c8b (diff) | |
| download | openvswitch-6e492d81450217a5c90cbb4ad31d81b1e611989b.tar.gz | |
Rearrange structures to better fit valgrind's memory leak heuristics.
valgrind's memory leak detector considers a pointer to the head of a memory
block to be "definitely" a pointer to that memory block but a pointer to
the interior of a memory block only "possibly" a pointer to that memory
block. Open vSwitch hmap_node and list data structures can go anywhere
inside a structure; if they are in the middle of a structure then valgrind
considers pointers to them to be possible leaks. Therefore, this commit
moves some of these from the middle of data structures to the head, to
reduce valgrind's uncertainty.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'ovsdb/row.h')
| -rw-r--r-- | ovsdb/row.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ovsdb/row.h b/ovsdb/row.h index 2fdc72ef5..306a56da6 100644 --- a/ovsdb/row.h +++ b/ovsdb/row.h @@ -1,4 +1,4 @@ -/* Copyright (c) 2009, 2010, 2011 Nicira Networks +/* Copyright (c) 2009, 2010, 2011, 2012 Nicira Networks * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -43,8 +43,8 @@ struct ovsdb_weak_ref { /* A row in a database table. */ struct ovsdb_row { - struct ovsdb_table *table; /* Table to which this belongs. */ struct hmap_node hmap_node; /* Element in ovsdb_table's 'rows' hmap. */ + struct ovsdb_table *table; /* Table to which this belongs. */ struct ovsdb_txn_row *txn_row; /* Transaction that row is in, if any. */ /* Weak references. */ |