diff options
| author | Justin Pettit <jpettit@nicira.com> | 2011-02-21 17:02:35 -0800 |
|---|---|---|
| committer | Justin Pettit <jpettit@nicira.com> | 2011-02-22 10:14:53 -0800 |
| commit | f7c21036f9cc592727b791f9e7bee8bc75ed7285 (patch) | |
| tree | aa8a6bc581ad28287950030feaafc62dd2b9062a /ovsdb | |
| parent | 08871bf6f0ac5dd8afc6a571b43e7948de4ac832 (diff) | |
| download | openvswitch-f7c21036f9cc592727b791f9e7bee8bc75ed7285.tar.gz | |
ovsdb: Don't check "date" before assignment in ovsdb_file_txn_from_json().
There's no indication that "date" is optional in the description of
ovsdb_file_txn_from_json(), and the one caller always passes it in, so
don't bother checking whether it exists.
Coverity #10732
Diffstat (limited to 'ovsdb')
| -rw-r--r-- | ovsdb/file.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ovsdb/file.c b/ovsdb/file.c index 7061d6820..bf72316cc 100644 --- a/ovsdb/file.c +++ b/ovsdb/file.c @@ -404,9 +404,7 @@ ovsdb_file_txn_from_json(struct ovsdb *db, const struct json *json, if (!table) { if (!strcmp(table_name, "_date") && node_json->type == JSON_INTEGER) { - if (date) { - *date = json_integer(node_json); - } + *date = json_integer(node_json); continue; } else if (!strcmp(table_name, "_comment") || converting) { continue; |
