diff options
| author | Ben Pfaff <blp@nicira.com> | 2011-08-22 14:31:18 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2011-08-24 11:57:42 -0700 |
| commit | 523a3bc7733b13cbfb4b702739cd26d0c29b05f7 (patch) | |
| tree | d2293ddd9c03e29696f9a0bf6aeb2b2d87fb3ba4 /python/ovs/db | |
| parent | 57d6a4c71bd0b4ed477ec273d4d4f84c5e4ed465 (diff) | |
| download | openvswitch-523a3bc7733b13cbfb4b702739cd26d0c29b05f7.tar.gz | |
python: Use getattr() and setattr() instead of __dict__.
This leaves one use of __dict__ used for iterating through attributes.
I could use dir() instead, but I was put off by this note in its
documentation in the Python Library Reference:
Because dir() is supplied primarily as a convenience for use at an
interactive prompt, it tries to supply an interesting set of names more
than it tries to supply a rigorously or consistently defined set of names,
and its detailed behavior may change across releases. For example,
metaclass attributes are not in the result list when the argument is a
class.
Suggested-by: Reid Price <reid@nicira.com>
Diffstat (limited to 'python/ovs/db')
| -rw-r--r-- | python/ovs/db/idl.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py index 5260d983f..1ee330e98 100644 --- a/python/ovs/db/idl.py +++ b/python/ovs/db/idl.py @@ -271,8 +271,8 @@ class Idl: % (column_name, table_name, e)) continue - if datum != row.__dict__[column_name]: - row.__dict__[column_name] = datum + if datum != getattr(row, column_name): + setattr(row, column_name, datum) changed = True else: # Didn't really change but the OVSDB monitor protocol always @@ -296,7 +296,7 @@ class Idl: pass row = self.data[table.name][uuid] = Row() for column in table.columns.itervalues(): - row.__dict__[column.name] = ovs.db.data.Datum.default(column.type) + setattr(row, column.name, ovs.db.data.Datum.default(column.type)) return row def force_reconnect(self): |