diff options
| author | Timothy Redaelli <tredaelli@redhat.com> | 2018-04-03 15:38:28 +0200 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2018-04-04 10:39:17 -0700 |
| commit | 1436dbec35869a4f99f2e6c32ad60cf22d1d1ea5 (patch) | |
| tree | 4f6123a8a09b25681204bc026a65d07f7cc37536 /tests/automake.mk | |
| parent | b97b1f0f884b8b47ea6fa7a70628cee9eaf69d4c (diff) | |
| download | openvswitch-1436dbec35869a4f99f2e6c32ad60cf22d1d1ea5.tar.gz | |
tests: Allow only 1 job at once during recheck (RECHECK=yes)
Currently some tests fail frequently if run with multiple jobs at once, so
this commit disables parallel jobs during the recheck phase.
Some tests fails often than other tests (when run in multiple jobs), so
rarely (on a big machine, with 32 cores and by using -j32) a test
fails twice and so make check RECHECK=yes fails.
This patch only avoid this rare failure that can be annoying if you are
releasing a new package (on Fedora or RHEL for example) since you need
to re-build all the architectures only for a false positive on a
single architecture.
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'tests/automake.mk')
| -rw-r--r-- | tests/automake.mk | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/automake.mk b/tests/automake.mk index bab91a466..d9292e80c 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -141,7 +141,7 @@ AUTOTEST_PATH = utilities:vswitchd:ovsdb:vtep:tests:$(PTHREAD_WIN32_DIR_DLL):$(S check-local: set $(SHELL) '$(TESTSUITE)' -C tests AUTOTEST_PATH=$(AUTOTEST_PATH) $(TESTSUITEFLAGS); \ - "$$@" || (test X'$(RECHECK)' = Xyes && "$$@" --recheck) + "$$@" || (test X'$(RECHECK)' = Xyes && "$$@" -j1 --recheck) # Python Coverage support. # Requires coverage.py http://nedbatchelder.com/code/coverage/. @@ -169,7 +169,7 @@ GENHTML_OPTS = -q --branch-coverage --num-spaces 4 check-lcov: all $(check_DATA) clean-lcov find . -name '*.gcda' | xargs -n1 rm -f -set $(SHELL) '$(TESTSUITE)' -C tests AUTOTEST_PATH=$(AUTOTEST_PATH) $(TESTSUITEFLAGS); \ - "$$@" || (test X'$(RECHECK)' = Xyes && "$$@" --recheck) + "$$@" || (test X'$(RECHECK)' = Xyes && "$$@" -j1 --recheck) $(MKDIR_P) tests/lcov lcov $(LCOV_OPTS) -o tests/lcov/coverage.info genhtml $(GENHTML_OPTS) -o tests/lcov tests/lcov/coverage.info |