diff options
| author | Ben Pfaff <blp@nicira.com> | 2012-04-02 09:06:11 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2012-04-02 09:06:11 -0700 |
| commit | cd03c7c85997b24070ee20c5995cefac47447e40 (patch) | |
| tree | 862b41a5c67e089ab3b0918adc8bf10807c83f24 /tests/check-structs.at | |
| parent | 6b05acf8171a3fdb4f55a12f8af55cc25f222657 (diff) | |
| download | openvswitch-cd03c7c85997b24070ee20c5995cefac47447e40.tar.gz | |
check-structs: Disallow uint<N>_t because ovs_be<N> should always be used.
The header files that check-structs checks should only contain big-endian
data, never native-endian data, so disallow uint<N>_t entirely. (We had
a couple of mistakes in this area until recently.)
uint8_t is an obvious exception.
Reported-by: Simon Horman <horms@verge.net.au>
Reviewed-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'tests/check-structs.at')
| -rw-r--r-- | tests/check-structs.at | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/check-structs.at b/tests/check-structs.at index a926a0fb5..4163c30d6 100644 --- a/tests/check-structs.at +++ b/tests/check-structs.at @@ -11,7 +11,7 @@ m4_define([RUN_STRUCT_CHECKER], AT_SETUP([check struct tail padding]) RUN_STRUCT_CHECKER( [struct xyz { - uint16_t x; + ovs_be16 x; };], [1], [], [test.h:3: warning: struct xyz needs 2 bytes of tail padding @@ -21,8 +21,8 @@ AT_CLEANUP AT_SETUP([check struct internal alignment]) RUN_STRUCT_CHECKER( [struct xyzzy { - uint16_t x; - uint32_t y; + ovs_be16 x; + ovs_be32 y; };], [1], [], [test.h:3: warning: struct xyzzy member y is 2 bytes short of 4-byte alignment @@ -32,7 +32,7 @@ AT_CLEANUP AT_SETUP([check struct declared size]) RUN_STRUCT_CHECKER( [struct wibble { - uint64_t z; + ovs_be64 z; }; OFP_ASSERT(sizeof(struct wibble) == 12); ], @@ -44,11 +44,11 @@ AT_CLEANUP AT_SETUP([check wrong struct's declared size]) RUN_STRUCT_CHECKER( [struct moo { - uint64_t bar; + ovs_be64 bar; }; OFP_ASSERT(sizeof(struct moo) == 8); struct wibble { - uint64_t z; + ovs_be64 z; }; OFP_ASSERT(sizeof(struct moo) == 8); ], [1], [], [test.h:8: warning: checking size of struct moo but struct wibble was most recently defined |