diff options
| author | Ben Pfaff <blp@nicira.com> | 2010-02-23 15:57:50 -0800 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2010-02-25 14:59:16 -0800 |
| commit | 89521e3f79d53523fda9f284e74f0f7aa21332b4 (patch) | |
| tree | 3e3463784a9fe29afb78df4cdc7e624c05e20317 /tests/ovsdb-types.at | |
| parent | 867cc7bd395b32a3516112127a04d41d9f1b15fc (diff) | |
| download | openvswitch-89521e3f79d53523fda9f284e74f0f7aa21332b4.tar.gz | |
ovsdb: Drop regular expression constraints.
Regular expression constraints have caused nothing but trouble due to the
lack of a ubiquitous regular expression library. PCRE is *almost*
everywhere, but it has different versions, and different features, and
different bugs, in different places. It is more trouble than it is worth.
So this commit drops support.
Diffstat (limited to 'tests/ovsdb-types.at')
| -rw-r--r-- | tests/ovsdb-types.at | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/tests/ovsdb-types.at b/tests/ovsdb-types.at index d05277666..2d981833c 100644 --- a/tests/ovsdb-types.at +++ b/tests/ovsdb-types.at @@ -44,31 +44,6 @@ OVSDB_CHECK_NEGATIVE([real max may not be less than min], OVSDB_CHECK_POSITIVE([boolean], [[parse-base-type '[{"type": "boolean"}]' ]], ["boolean"]) -OVSDB_CHECK_POSITIVE([string reMatch], - [[parse-base-type '{"type": "string", "reMatch": "\\d{3}-\\d{3}-\\d{4}"}']], - [{"reMatch":"\\d{3}-\\d{3}-\\d{4}","type":"string"}]) -OVSDB_CHECK_POSITIVE([string reMatch + reComment], - [[parse-base-type '{"type": "string", "reMatch": "\\d{3}-\\d{3}-\\d{4}", "reComment": "US-style telephone number"}']], - [{"reComment":"US-style telephone number","reMatch":"\\d{3}-\\d{3}-\\d{4}","type":"string"}]) - -AT_SETUP([reMatch must be a valid regexp]) -AT_KEYWORDS([ovsdb negative]) -if test "$HAVE_PCRE" = yes; then - AT_CHECK( - [[test-ovsdb parse-base-type \ - '{"type": "string", "reMatch": "x{2,1}"}']], - [1], [], - [[test-ovsdb: invalid regular expression: "x{2,1}" is not a valid regular expression: numbers out of order in {} quantifier -]]) -else - AT_CHECK( - [[test-ovsdb parse-base-type \ - '{"type": "string", "reMatch": "x{2,1}"}']], - [0], [[{"reMatch":"x{2,1}","type":"string"} -]], []) -fi -AT_CLEANUP - OVSDB_CHECK_POSITIVE([string minLength], [[parse-base-type '{"type": "string", "minLength": 1}']], [{"minLength":1,"type":"string"}]) |