summaryrefslogtreecommitdiff
path: root/utilities
diff options
context:
space:
mode:
authorAaron Conole <aconole@bytheb.org>2016-10-21 14:49:03 -0400
committerBen Pfaff <blp@ovn.org>2016-11-28 17:01:05 -0800
commit3239c7937c8f142cef4e3ee82ce22f0c658143e3 (patch)
treeacd08b70f39aac694f65bb1325f814a12a6006fb /utilities
parentca3d4f55fbd80cb8db2b878aa95a2d00c2635efe (diff)
downloadopenvswitch-3239c7937c8f142cef4e3ee82ce22f0c658143e3.tar.gz
checkpatch: Announce the file where errors occur
This makes finding the warning and error marks much easier. Signed-off-by: Aaron Conole <aconole@bytheb.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'utilities')
-rwxr-xr-xutilities/checkpatch.py13
1 files changed, 13 insertions, 0 deletions
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 754059afe..15b59a3be 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -21,10 +21,19 @@ import sys
__errors = 0
__warnings = 0
+print_file_name = None
+
+
+def print_file():
+ global print_file_name
+ if print_file_name:
+ print("In file %s" % print_file_name)
+ print_file_name = None
def print_error(message, lineno=None):
global __errors
+ print_file()
if lineno is not None:
print("E(%d): %s" % (lineno, message))
else:
@@ -35,6 +44,7 @@ def print_error(message, lineno=None):
def print_warning(message, lineno=None):
global __warnings
+ print_file()
if lineno:
print("W(%d): %s" % (lineno, message))
else:
@@ -131,6 +141,7 @@ def if_and_for_end_with_bracket_check(line):
def ovs_checkpatch_parse(text):
+ global print_file_name
lineno = 0
signatures = []
co_authors = []
@@ -162,6 +173,7 @@ def ovs_checkpatch_parse(text):
if match:
parse = parse + 1
current_file = match.group(2)
+ print_file_name = current_file
continue
elif parse == 0:
if scissors.match(line):
@@ -185,6 +197,7 @@ def ovs_checkpatch_parse(text):
newfile = hunks.match(line)
if newfile:
current_file = newfile.group(2)
+ print_file_name = current_file
continue
if not is_added_line(line):
continue