diff options
| author | Adrian Moreno <amorenoz@redhat.com> | 2022-03-23 12:56:17 +0100 |
|---|---|---|
| committer | Ilya Maximets <i.maximets@ovn.org> | 2022-03-30 16:59:02 +0200 |
| commit | 9e56549c2bba79e644de2d3876b363553175210c (patch) | |
| tree | bf0bf39f86c3e63eda7171f727a6ca3dcc69922b /utilities | |
| parent | 860e69a8c3d6994dc000b37d682bd16cd2925bef (diff) | |
| download | openvswitch-9e56549c2bba79e644de2d3876b363553175210c.tar.gz | |
hmap: use short version of safe loops if possible.
Using SHORT version of the *_SAFE loops makes the code cleaner and less
error prone. So, use the SHORT version and remove the extra variable
when possible for hmap and all its derived types.
In order to be able to use both long and short versions without changing
the name of the macro for all the clients, overload the existing name
and select the appropriate version depending on the number of arguments.
Acked-by: Dumitru Ceara <dceara@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Diffstat (limited to 'utilities')
| -rw-r--r-- | utilities/ovs-vsctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index 812455eea..14f5cb92e 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -1525,11 +1525,11 @@ del_port(struct vsctl_context *vsctl_ctx, struct vsctl_port *port) static void del_bridge(struct vsctl_context *vsctl_ctx, struct vsctl_bridge *br) { - struct vsctl_bridge *child, *next_child; + struct vsctl_bridge *child; struct vsctl_port *port; const struct ovsrec_flow_sample_collector_set *fscset, *next_fscset; - HMAP_FOR_EACH_SAFE (child, next_child, children_node, &br->children) { + HMAP_FOR_EACH_SAFE (child, children_node, &br->children) { del_bridge(vsctl_ctx, child); } |