summaryrefslogtreecommitdiff
path: root/utilities
diff options
context:
space:
mode:
authorJustin Pettit <jpettit@nicira.com>2011-02-21 17:19:18 -0800
committerJustin Pettit <jpettit@nicira.com>2011-02-22 10:14:53 -0800
commita6c8e0d9e99f1eb341d87df26b6fa02dc051f4a0 (patch)
treed6cef6d52a8f346c12fde81faf38d58451eabdd2 /utilities
parentf7c21036f9cc592727b791f9e7bee8bc75ed7285 (diff)
downloadopenvswitch-a6c8e0d9e99f1eb341d87df26b6fa02dc051f4a0.tar.gz
ovs-vsctl: Check "key" is valid before dereferencing in get_external_id().
Coverity #10716
Diffstat (limited to 'utilities')
-rw-r--r--utilities/ovs-vsctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 31c485bab..9fca1c8e3 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -1403,7 +1403,7 @@ get_external_id(char **keys, char **values, size_t n,
if (!key && !strncmp(keys[i], prefix, prefix_len)) {
svec_add_nocopy(&svec, xasprintf("%s=%s",
keys[i] + prefix_len, values[i]));
- } else if (key_matches(keys[i], prefix, prefix_len, key)) {
+ } else if (key && key_matches(keys[i], prefix, prefix_len, key)) {
svec_add(&svec, values[i]);
break;
}