summaryrefslogtreecommitdiff
path: root/utilities
diff options
context:
space:
mode:
authorWang Yibo <bobxxwang@126.com>2021-05-06 11:14:07 +0800
committerIlya Maximets <i.maximets@ovn.org>2021-05-14 16:08:43 +0200
commitf173527ec8a42e79e0a322ebe4bed999ea9ba497 (patch)
tree67c1477fb81cce4700eb5ee876c7638ea5e1f960 /utilities
parent3c2d6274bceecb65ec8f2f93f2aac26897a7ddfe (diff)
downloadopenvswitch-f173527ec8a42e79e0a322ebe4bed999ea9ba497.tar.gz
ovs-ofctl: Fix coredump when using "add-groups" command.
When using ovs-ofctl add-groups with only "switch" argument, a coredump is generated. The main reason is that the command "ovs-ofctl add-groups" need two arguments but the limitation of min-args of this command is set to 1. Fixes: 7395c05254df ("Implement OpenFlow 1.1+ "groups" protocol.") Submitted-at: https://github.com/openvswitch/ovs/pull/360 Signed-off-by: Wang Yibo <bobxxwang@126.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Diffstat (limited to 'utilities')
-rw-r--r--utilities/ovs-ofctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 62059e962..ede7f1e61 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -5051,7 +5051,7 @@ static const struct ovs_cmdl_command all_commands[] = {
{ "add-group", "switch group",
1, 2, ofctl_add_group, OVS_RW },
{ "add-groups", "switch file",
- 1, 2, ofctl_add_groups, OVS_RW },
+ 2, 2, ofctl_add_groups, OVS_RW },
{ "mod-group", "switch group",
1, 2, ofctl_mod_group, OVS_RW },
{ "del-groups", "switch [group]",