summaryrefslogtreecommitdiff
path: root/vswitchd
diff options
context:
space:
mode:
authorHan Zhou <hzhou@ovn.org>2023-01-16 19:01:29 -0800
committerIlya Maximets <i.maximets@ovn.org>2023-01-27 16:09:10 +0100
commite5b3cb9995445cd83ab1d2811bfd79ca03dd46d4 (patch)
tree1fe5906650bca821ee7dd35da826c154eeb31ede /vswitchd
parentebaee446240133f5ec5064553535dfe392f60999 (diff)
downloadopenvswitch-e5b3cb9995445cd83ab1d2811bfd79ca03dd46d4.tar.gz
revalidator: Allow min-revalidator-pps to be 0.
Today the minimum value for this setting is 1. This patch allows it to be 0, meaning not checking pps at all, and always do revalidation. This is particularly useful for environments where some of the applications with long-lived connections may have very low traffic for certain period but have high rate of burst periodically. It is desirable to keep the datapath flows instead of periodically deleting them to avoid burst of packet miss to userspace. When setting to 0, there may be more datapath flows to be revalidated, resulting in higher CPU cost of revalidator threads. This is the downside but in certain cases this is still more desirable than packet misses to user space. Signed-off-by: Han Zhou <hzhou@ovn.org> Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Diffstat (limited to 'vswitchd')
-rw-r--r--vswitchd/vswitch.xml3
1 files changed, 2 insertions, 1 deletions
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 2b57fc0e3..64f23302d 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -205,10 +205,11 @@
</column>
<column name="other_config" key="min-revalidate-pps"
- type='{"type": "integer", "minInteger": 1}'>
+ type='{"type": "integer", "minInteger": 0}'>
<p>
Set minimum pps that flow must have in order to be revalidated when
revalidation duration exceeds half of max-revalidator config variable.
+ Setting to 0 means always revalidate flows regardless of pps.
</p>
<p>
The default is 5.