summaryrefslogtreecommitdiff
path: root/vtep
diff options
context:
space:
mode:
authorBen Pfaff <blp@ovn.org>2017-08-02 15:03:06 -0700
committerBen Pfaff <blp@ovn.org>2017-08-02 15:03:35 -0700
commit71f21279f62c2cca39ff1522f4d25b5de74992e3 (patch)
treea97490d3be210eb0ae0813a2aea69ef160ffc57f /vtep
parentb24fa3f486d4061cb9facd181fd6234f281904df (diff)
downloadopenvswitch-71f21279f62c2cca39ff1522f4d25b5de74992e3.tar.gz
Eliminate most shadowing for local variable names.
Shadowing is when a variable with a given name in an inner scope hides a different variable with the same name in a surrounding scope. This is generally undesirable because it can confuse programmers. This commit eliminates most of it. Found with -Wshadow=local in GCC 7. The repo is not really ready to enable this option by default because of a few cases that are harder to fix, and harmless, such as nested use of CMAP_FOR_EACH. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
Diffstat (limited to 'vtep')
-rw-r--r--vtep/vtep-ctl.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
index 17afa0c59..0b984f0a5 100644
--- a/vtep/vtep-ctl.c
+++ b/vtep/vtep-ctl.c
@@ -1086,7 +1086,6 @@ vtep_ctl_context_populate_cache(struct ctl_context *ctx)
port = add_port_to_cache(vtepctl_ctx, ps, port_cfg);
for (k = 0; k < port_cfg->n_vlan_bindings; k++) {
- struct vteprec_logical_switch *ls_cfg;
struct vtep_ctl_lswitch *ls;
char *vlan;