diff options
| -rw-r--r-- | NEWS | 4 | ||||
| -rw-r--r-- | ofproto/ofproto-dpif.c | 4 | ||||
| -rw-r--r-- | utilities/ovs-ofctl.8.in | 5 |
3 files changed, 9 insertions, 4 deletions
@@ -18,6 +18,10 @@ Post-v2.16.0 get or configure linux kernel datapath cache sizes. - ovs-ofctl dump-flows no longer prints "igmp". Instead the flag "ip,nw_proto=2" is used. + - OpenFlow: + * Default selection method for select groups with up to 256 buckets is + now dp_hash. Previously this was limited to 64 buckets. This change + is mainly for the benefit of OVN load balancing configurations. v2.16.0 - 16 Aug 2021 diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index cba49a99e..bc3df8ea1 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -5152,9 +5152,9 @@ group_set_selection_method(struct group_dpif *group) if (selection_method[0] == '\0') { VLOG_DBG("No selection method specified. Trying dp_hash."); /* If the controller has not specified a selection method, check if - * the dp_hash selection method with max 64 hash values is appropriate + * the dp_hash selection method with max 256 hash values is appropriate * for the given bucket configuration. */ - if (group_setup_dp_hash_table(group, 64)) { + if (group_setup_dp_hash_table(group, 256)) { /* Use dp_hash selection method with symmetric L4 hash. */ group->selection_method = SEL_METHOD_DP_HASH; group->hash_alg = OVS_HASH_ALG_SYM_L4; diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 2017c6eba..e903ca12b 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -1083,8 +1083,9 @@ This field is optional for \fBadd\-group\fR, \fBadd\-groups\fR and otherwise. If no selection method is specified, Open vSwitch up to release 2.9 applies the \fBhash\fR method with default fields. From 2.10 onwards Open vSwitch defaults to the \fBdp_hash\fR method with symmetric -L3/L4 hash algorithm, unless the weighted group buckets cannot be mapped to -a maximum of 64 dp_hash values with sufficient accuracy. +L3/L4 hash algorithm, as long as the weighted group buckets can be mapped to +dp_hash values with sufficient accuracy. In 2.10 this was restricted to a +maximum of 64 buckets, and in 2.17 the limit was raised to 256 buckets. In those rare cases Open vSwitch 2.10 and later fall back to the \fBhash\fR method with the default set of hash fields. .RS |