diff options
| author | Hauke Mehrtens <hauke@hauke-m.de> | 2019-09-02 22:27:35 +0200 |
|---|---|---|
| committer | Jo-Philipp Wich <jo@mein.io> | 2019-09-03 11:54:22 +0200 |
| commit | 4d0c703e750cdbaa7d8afc56de05bd1238e3c981 (patch) | |
| tree | 2e2ef398d92e32bcc36e70367f9bec963fa8ff94 /redirects.c | |
| parent | 8c404ef02f0122ec90b48e122777ff6bfa715d7f (diff) | |
| download | firewall3-4d0c703e750cdbaa7d8afc56de05bd1238e3c981.tar.gz | |
firewall3: Fix some format string problems
This adds annotations for the format strings to the print functions and
fixes the newly found problems. One of them is a format security
problem.
Coverity: #1412532
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Diffstat (limited to 'redirects.c')
| -rw-r--r-- | redirects.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/redirects.c b/redirects.c index 97529ee..d376555 100644 --- a/redirects.c +++ b/redirects.c @@ -254,14 +254,13 @@ check_redirect(struct fw3_state *state, struct fw3_redirect *redir, struct uci_e } else if (redir->ipset.set && state->disable_ipsets) { - warn_section("redirect", redir, e, "skipped due to disabled ipset support", - redir->name); + warn_section("redirect", redir, e, "skipped due to disabled ipset support"); return false; } else if (redir->ipset.set && !(redir->ipset.ptr = fw3_lookup_ipset(state, redir->ipset.name))) { - warn_section("redirect", redir, e, "refers to unknown ipset '%s'", redir->name, + warn_section("redirect", redir, e, "refers to unknown ipset '%s'", redir->ipset.name); return false; } |