summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRafał Miłecki <rafal@milecki.pl>2018-12-09 14:22:17 +0100
committerRafał Miłecki <rafal@milecki.pl>2018-12-09 14:22:17 +0100
commit30f509686d8abc2ffd7fe34401d00cf7a86d8ea9 (patch)
treeeffe7c50e8be4d74e10aae554a5ef205a1546e3a
parentdc6a462997db36e860a97e49f2a3e5f4f4ac4d34 (diff)
downloadfstools-30f509686d8abc2ffd7fe34401d00cf7a86d8ea9.tar.gz
block: validate amount of arguments for the "autofs" command
Using argv[3] without checking argc value could result in undefined behavior. It could result in a crash or accessing a NULL that separates argv from envp on UNIX. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Acked-by: John Crispin <john@phrozen.org>
-rw-r--r--block.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/block.c b/block.c
index 46050b4..a0bbf47 100644
--- a/block.c
+++ b/block.c
@@ -1157,6 +1157,10 @@ static int main_autofs(int argc, char **argv)
}
return 0;
}
+
+ if (argc < 4)
+ return -EINVAL;
+
return mount_action(argv[2], argv[3], TYPE_AUTOFS);
}