diff options
| author | Petr Štetiar <ynezz@true.cz> | 2019-10-04 16:56:12 +0200 |
|---|---|---|
| committer | rofl0r <rofl0r@users.noreply.github.com> | 2022-09-16 01:27:56 +0000 |
| commit | 0aeb127f3cfe4abbc9a894c236541467396ed5ff (patch) | |
| tree | 84cb32664810642e8edc2ddd7f6b3ed60ba452df /msg.c | |
| parent | 31e166fa8130bef975f85d2c83f69e0619f3289a (diff) | |
| download | libnl-tiny-0aeb127f3cfe4abbc9a894c236541467396ed5ff.tar.gz | |
iron out all extra compiler warnings
gcc 9.1 on x86/64 has reported following:
attr.c:403:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
genl.c:154:24: error: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
genl_mngt.c:157:22: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
msg.c:190:20: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
msg.c:192:18: error: comparison of integer expressions of different signedness: ‘__u32’ {aka ‘const unsigned int’} and ‘int’ [-Werror=sign-compare]
msg.c:361:10: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
nl.c:428:18: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
nl.c:602:23: error: comparison of integer expressions of different signedness: ‘__u32’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
Signed-off-by: Petr Štetiar <ynezz@true.cz>
Diffstat (limited to 'msg.c')
| -rw-r--r-- | msg.c | 8 |
1 files changed, 5 insertions, 3 deletions
@@ -187,9 +187,11 @@ static size_t default_msg_size = 4096; */ int nlmsg_ok(const struct nlmsghdr *nlh, int remaining) { - return (remaining >= sizeof(struct nlmsghdr) && + size_t r = remaining; + + return (r >= sizeof(struct nlmsghdr) && nlh->nlmsg_len >= sizeof(struct nlmsghdr) && - nlh->nlmsg_len <= remaining); + nlh->nlmsg_len <= r); } /** @@ -358,7 +360,7 @@ struct nl_msg *nlmsg_alloc_simple(int nlmsgtype, int flags) */ void nlmsg_set_default_size(size_t max) { - if (max < nlmsg_total_size(0)) + if (max < (size_t) nlmsg_total_size(0)) max = nlmsg_total_size(0); default_msg_size = max; |