summaryrefslogtreecommitdiff
path: root/nl.c
Commit message (Collapse)AuthorAgeFilesLines
* remove never used err variable assignment disliked by scan-buildPetr Štetiar2022-09-161-1/+0
| | | | | | | | | | scan-build from clang version 9 complains about following: nl.c:648:3: warning: Value stored to 'err' is never read err = 0; ^ ~ Signed-off-by: Petr Štetiar <ynezz@true.cz>
* silence use after the free clang analyzer warningPetr Štetiar2022-09-161-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | scan-build from clang version 9 complains about following: nl.c:507:9: warning: Use of memory after it is freed while (nlmsg_ok(hdr, n)) { ^~~~~~~~~~~~~~~~ which seems to be impossible codepath as clang analyzer doesn't somehow account properly nl_syserr2nlerr(errno) return value: } else { free(msg.msg_control); free(*buf); return -nl_syserr2nlerr(errno); } which should be always < 0, but analyzer is still checking for > 0 code path as well for some reason. So in order to make the analyzer happy, set the buf pointer to NULL explicitly and add assert to make it clear, that this codepath should never happen. Signed-off-by: Petr Štetiar <ynezz@true.cz>
* iron out all extra compiler warningsPetr Štetiar2022-09-161-2/+2
| | | | | | | | | | | | | | | gcc 9.1 on x86/64 has reported following: attr.c:403:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare] genl.c:154:24: error: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare] genl_mngt.c:157:22: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare] msg.c:190:20: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare] msg.c:192:18: error: comparison of integer expressions of different signedness: ‘__u32’ {aka ‘const unsigned int’} and ‘int’ [-Werror=sign-compare] msg.c:361:10: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare] nl.c:428:18: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare] nl.c:602:23: error: comparison of integer expressions of different signedness: ‘__u32’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare] Signed-off-by: Petr Štetiar <ynezz@true.cz>
* libnl-tiny: Generic Netlink multicast groups supportHauke Mehrtens2022-09-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds this commit from normal libnl to libnl-tiny: https://github.com/tgraf/libnl/commit/2dbc1ca76c5b82c40749e609eb83877418abb006 commit 2dbc1ca76c5b82c40749e609eb83877418abb006 Author: dima <dima.ky@gmail.com> Date: Wed Oct 13 17:53:34 2010 +0300 Generic Netlink multicast groups support I have a patch against commit d378220c96c3c8b6f27dca33e7d8ba03318f9c2d extending libnl with a facility to receive generic netlink messages sent to multicast groups. Essentially it add one new function genl_ctrl_resolve_grp which prototype looks like this int genl_ctrl_resolve_grp(struct nl_sock *sk, const char *family_name, const char *grp_name) It resolves the family name and the group name to group id. Then the returned id can be used in nl_socket_add_membership to subscribe to multicast messages. Besides that it adds two more functions uint32_t nl_socket_get_peer_groups(struct nl_sock *sk) void nl_socket_set_peer_groups(struct nl_sock *sk, uint32_t groups) allowing to modify the socket peer groups field. So it's possible to multicast messages from the user space using the legacy interface. Looks like there is no way (or I was not able to find one?) to modify the netlink socket destination group from the user space, when the group id is greater then 32. Signed-off-by: Hauke Mehrtens <hauke.mehrtens@intel.com> Signed-off-by: Felix Fietkau <nbd@nbd.name> [cosmetic style fix]
* libnl-tiny: fix receiving netlink messages larger than 4KJonas Gorski2022-09-161-1/+1
| | | | | | | | | | | | | | Apply libnl commit 807fddc4cd9ecb12ba64e1b7fa26d86b6c2f19b0 ("nl: Increase receive buffer size to 4 pages") also to libnl-tiny to ensure netlink messages larger than 4KiB can be received, as the restart logic seems to be broken. This fixes iwinfo accessing info on dual band b43 cards, as they can support a lot of channels, breaking the 4K default limit (seen was >5k). Signed-off-by: Jonas Gorski <jogo@openwrt.org> SVN-Revision: 43633
* move files into toplevel dirrofl0r2014-07-101-0/+720