summaryrefslogtreecommitdiff
path: root/bridge.c
diff options
context:
space:
mode:
authorMatthias Schiffer <mschiffer@universe-factory.net>2015-01-27 03:49:52 +0100
committerJohn Crispin <blogic@openwrt.org>2015-03-23 07:50:21 +0100
commitef4b8c8446b5f164a310a3955e90f7ffd59e2a59 (patch)
tree575dd71e818b187598dc8aab8f05831bed290368 /bridge.c
parent20510bd45d70c5b07718e7608d82133883346673 (diff)
downloadnetifd-ef4b8c8446b5f164a310a3955e90f7ffd59e2a59.tar.gz
bridge: allow enabling or disabling the multicast querier independently of IGMP snooping
In larger networks, especially big batman-adv meshes, it may be desirable to enable IGMP snooping on every bridge without enabling the multicast querier to specifically put the querier on a well-connected node. This patch adds a new UCI option 'multicast_querier' for bridges which allows this. The default is still the value of the 'igmp_snooping' option to maintain backwards compatiblity. Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Diffstat (limited to 'bridge.c')
-rw-r--r--bridge.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/bridge.c b/bridge.c
index 7076fd7..c5e17a4 100644
--- a/bridge.c
+++ b/bridge.c
@@ -32,6 +32,7 @@ enum {
BRIDGE_ATTR_HELLO_TIME,
BRIDGE_ATTR_MAX_AGE,
BRIDGE_ATTR_BRIDGE_EMPTY,
+ BRIDGE_ATTR_MULTICAST_QUERIER,
__BRIDGE_ATTR_MAX
};
@@ -45,6 +46,7 @@ static const struct blobmsg_policy bridge_attrs[__BRIDGE_ATTR_MAX] = {
[BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
[BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
[BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
+ [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
};
static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
@@ -548,6 +550,7 @@ bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
cfg->stp = false;
cfg->forward_delay = 2;
cfg->igmp_snoop = true;
+ cfg->multicast_querier = true;
cfg->bridge_empty = false;
cfg->priority = 0x7FFF;
@@ -561,7 +564,10 @@ bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
cfg->priority = blobmsg_get_u32(cur);
if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
- cfg->igmp_snoop = blobmsg_get_bool(cur);
+ cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
+
+ if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
+ cfg->multicast_querier = blobmsg_get_bool(cur);
if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
cfg->ageing_time = blobmsg_get_u32(cur);