device: gracefully handle device names exceeding IFNAMESIZ

Instead of truncating the device name when it exceeds IFNAMSIZ length;
let device_set_ifname return an error code and do not add the device
to the device list.
This avoids possible issues with device names becoming identical due the
truncation and as a result unexpected behavior.
Further let the different device types gracefully handle the error code
returned by device_init

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

1 files changed, 7 insertions, 1 deletions

diff --git a/tunnel.c b/tunnel.c
index 3fa3e21..1383384 100644
--- a/tunnel.c
+++ b/tunnel.c
@@ -72,7 +72,13 @@ tunnel_create(const char *name, struct device_type *devtype,
 		return NULL;
 
 	dev = &tun->dev;
-	device_init(dev, devtype, name);
+
+	if (device_init(dev, devtype, name) < 0) {
+		device_cleanup(dev);
+		free(tun);
+		return NULL;
+	}
+
 	tun->set_state = dev->set_state;
 	dev->set_state = tunnel_set_state;
 	device_apply_config(dev, devtype, attr);