diff options
author | Giovanni Giacobbi <giovanni@giacobbi.net> | 2021-07-27 14:39:28 +0200 |
---|---|---|
committer | Daniel Golle <daniel@makrotopia.org> | 2021-08-03 21:45:30 +0100 |
commit | 1f4f72bde55e8c5810db4ead4170352febd2dbfb (patch) | |
tree | 95643fa99dbc43f3c27f849f1a1b98390c344ab4 | |
parent | 41664054b8b1bc19d842421c49d1b4d612ff8297 (diff) | |
download | ubox-1f4f72bde55e8c5810db4ead4170352febd2dbfb.tar.gz |
logd: fix privilege dropping order
Fixes: 41664054b8b1 ("logd: fix ignored return values in set{gid,uid}")
Signed-off-by: Giovanni Giacobbi <giovanni@giacobbi.net>
-rw-r--r-- | log/logd.c | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -260,13 +260,13 @@ main(int argc, char **argv) ubus_auto_connect(&conn); p = getpwnam("logd"); if (p) { - if (setuid(p->pw_uid) < 0) { - fprintf(stderr, "setuid() failed: %s\n", strerror(errno)); + if (setgid(p->pw_gid) < 0) { + fprintf(stderr, "setgid() failed: %s\n", strerror(errno)); exit(1); } - if (setgid(p->pw_gid) < 0) { - fprintf(stderr, "setgid() failed: %s\n", strerror(errno)); + if (setuid(p->pw_uid) < 0) { + fprintf(stderr, "setuid() failed: %s\n", strerror(errno)); exit(1); } } |