| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | ubus_monitor: workaround possibly false positive uses of memory after it is ↵ | Petr Štetiar | 2019-12-19 | 1 | -1/+1 |
| | | | | | | | | | | | | freed scan-build from clang-9 has reported following: libubox/list.h:141:2: warning: Use of memory after it is freed _list_add(_new, head, head->next); Signed-off-by: Petr Štetiar <ynezz@true.cz> | ||||
| * | ubusd_monitor: fix possible null pointer dereference | Petr Štetiar | 2019-12-19 | 1 | -10/+30 |
| | | | | | | | | | | This dereference could possibly happen if the calloc call fails as the return value is unchecked. While at it refactor the code little bit to make it easier to follow, use safe list iterator and provide return value for ubusd_monitor_connect. Signed-off-by: Petr Štetiar <ynezz@true.cz> | ||||
| * | ubusd_monitor: alloc & free the buffer outside of the loop | Alexandru Ardelean | 2017-11-13 | 1 | -3/+5 |
| | | | | | | | | | Should save a few cycles, since the data that's being changed is only the seq number. And the `ub` is always created as shared. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> | ||||
| * | ubusd: don't free messages in ubus_send_msg() anymore | Alexandru Ardelean | 2017-11-13 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it clear that `ubus_msg_send()` is only about sending and queue-ing messages, and has nothing to do with free-ing. It can be a bit misleading/confusing when trying to go through the code and make assumptions about whether a buffer is free'd in ubus_send_msg(), or is free'd outside. In `ubusd_proto_receive_message()` the `ubus_msg_free()` is now called before the `if (ret == -1)` check. That way, all callbacks will have their messages free'd, which is what's desired, but confusing, because: * ubusd_handle_invoke() called ubus_msg_free() before returning -1 * ubusd_handle_notify() called ubus_msg_free() before returning -1 * ubusd_handle_response() called ubus_msg_send(,,free=true) before returning -1 * ubus_msg_send() would call ubus_msg_send(,,free=false) * all other callback callers would `ubus_msg_send(,,free=true)` (free the buffers in ubus_msg_send() ) In all other places, where `ubus_msg_send(,,free=true)` an explicit `ubus_msg_free()` was added. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> | ||||
| * | ubusd: add monitor support | Felix Fietkau | 2015-11-19 | 1 | -0/+110 |
| Signed-off-by: Felix Fietkau <nbd@openwrt.org> | |||||
 |
index : delta/openwrt/ubus.git | |
| git.openwrt.org: project/ubus.git |
| summaryrefslogtreecommitdiff |
path: root/ubusd_monitor.c