diff options
| author | Denis Pynkin <denis.pynkin@collabora.com> | 2020-02-18 00:46:51 +0300 |
|---|---|---|
| committer | Denis Pynkin <denis.pynkin@collabora.com> | 2020-03-25 15:23:55 +0300 |
| commit | 1e3bdef2851260b8ac3503744d4157d527e3823d (patch) | |
| tree | b3ca33dc9085df9cdbcc1737a83df710856931df | |
| parent | aaf73f6afca4c72ef9c7be6f64507babe7130a1b (diff) | |
| download | ostree-1e3bdef2851260b8ac3503744d4157d527e3823d.tar.gz | |
sign-dummy: optimize ostree_sign_dummy_data_verify
Return TRUE as soon as any signature verified.
Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
| -rw-r--r-- | src/libostree/ostree-sign-dummy.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/libostree/ostree-sign-dummy.c b/src/libostree/ostree-sign-dummy.c index b9d8abf4..722d461b 100644 --- a/src/libostree/ostree-sign-dummy.c +++ b/src/libostree/ostree-sign-dummy.c @@ -156,7 +156,6 @@ gboolean ostree_sign_dummy_data_verify (OstreeSign *self, if (!g_variant_is_of_type (signatures, (GVariantType *) OSTREE_SIGN_METADATA_DUMMY_TYPE)) return glnx_throw (error, "signature: dummy: wrong type passed for verification"); - gboolean verified = FALSE; for (gsize i = 0; i < g_variant_n_children(signatures); i++) { g_autoptr (GVariant) child = g_variant_get_child_value (signatures, i); @@ -169,12 +168,10 @@ gboolean ostree_sign_dummy_data_verify (OstreeSign *self, g_debug("Stored signature %d: %s", (gint)i, sign->pk_ascii); if (!g_strcmp0(sign_ascii, sign->pk_ascii)) - verified = TRUE; + return TRUE; else return glnx_throw (error, "signature: dummy: incorrect signature %" G_GSIZE_FORMAT, i); } - if (!verified) - return glnx_throw (error, "signature: dummy: no signatures"); - return TRUE; + return glnx_throw (error, "signature: dummy: no signatures"); } |