summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Walters <walters@verbum.org>2017-08-23 13:31:40 -0400
committerAtomic Bot <atomic-devel@projectatomic.io>2017-08-23 17:41:06 +0000
commit89801dd481d129fd98b21a0a7e418d15c073dc7b (patch)
treefbba0b383f7b7602b34915d964403b2e7d2aaf26
parenteb6f7c6db83ce384f89a142f173c2c064dad2f33 (diff)
downloadostree-89801dd481d129fd98b21a0a7e418d15c073dc7b.tar.gz
build/maint.mk: Comment out setting of LC_ALL
This triggers obscure bugs; really we shouldn't be overriding the global locale here. In practice, production build systems will be using fixed locales anyways. Also, we only use a small subset of this file (`make syntax-check`), which appears to work OK without this. I will probably try to work out where to submit this as at least an issue report for upstream gnulib. Closes: https://github.com/ostreedev/ostree/issues/1101 Closes: #1107 Approved by: heftig
-rw-r--r--maint.mk3
1 files changed, 2 insertions, 1 deletions
diff --git a/maint.mk b/maint.mk
index ff231c7d..09ab2401 100644
--- a/maint.mk
+++ b/maint.mk
@@ -105,7 +105,8 @@ my_distdir = $(PACKAGE)-$(VERSION)
# Prevent programs like 'sort' from considering distinct strings to be equal.
# Doing it here saves us from having to set LC_ALL elsewhere in this file.
-export LC_ALL = C
+# NOTE: commented out for https://github.com/ostreedev/ostree/issues/1101
+# export LC_ALL = C
## --------------- ##
## Sanity checks. ##