summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Walters <walters@verbum.org>2022-01-20 10:50:07 -0500
committerColin Walters <walters@verbum.org>2022-01-20 10:52:04 -0500
commit8c58195cc4b1c6d1c90cea3f7f6457e15f4f75bb (patch)
treeed1cecfabfb750dbf344f78478ee47d5fb3c06be
parent51361f62af929798b11e3f10038bff2b9496d87f (diff)
downloadostree-8c58195cc4b1c6d1c90cea3f7f6457e15f4f75bb.tar.gz
deploy: Also log to journal if we time out global sync()
We do implicitly have this data because we log timings via structured metadata in a later journal entry, but it's quite common to lose the structured metadata because a lot of tooling just grabs the default syslog-compatible text from `journalctl`. Let's be louder when we hit this case as a general rule too; I think most people shipping ostree systems want to see if it's happening.
-rw-r--r--src/libostree/ostree-sysroot-deploy.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/libostree/ostree-sysroot-deploy.c b/src/libostree/ostree-sysroot-deploy.c
index 6ee62410..726379d6 100644
--- a/src/libostree/ostree-sysroot-deploy.c
+++ b/src/libostree/ostree-sysroot-deploy.c
@@ -1647,7 +1647,10 @@ full_system_sync (OstreeSysroot *self,
while (!syncdata->success)
{
if (!g_cond_wait_until (&syncdata->cond, &syncdata->mutex, end_time))
- break;
+ {
+ ot_journal_print (LOG_INFO, "Timed out waiting for global sync()");
+ break;
+ }
}
g_mutex_unlock (&syncdata->mutex);
sync_data_unref (syncdata);