diff options
| author | Dan Nicholson <nicholson@endlessm.com> | 2018-10-12 12:18:36 +0000 |
|---|---|---|
| committer | Atomic Bot <atomic-devel@projectatomic.io> | 2018-10-12 12:34:57 +0000 |
| commit | 43d9cac4fc4f38c18b8aa164fbbf77609e2b5b10 (patch) | |
| tree | 629171bbcdc88323c705696e51b2734a13a82396 /src/libostree/ostree-repo-private.h | |
| parent | 9367a1befe045663a69265e10e0b4593068649e4 (diff) | |
| download | ostree-43d9cac4fc4f38c18b8aa164fbbf77609e2b5b10.tar.gz | |
lib/commit: Don't chown objects to repo target owner
The idea is that if the process is running as root, it can change
ownership of newly written files to match the owner of the repo.
Unfortunately, it currently applies in the other direction, too - a
non-root user writing to a root owned repository. If the repo is
writable by the user but owned by root, it can still create files and
directories there, but it can't change ownership of them.
This feature comes from
https://bugzilla.gnome.org/show_bug.cgi?id=738954. As it turns out, this
feature was never completed. It only works on content objects and not
metadata objects, refs, deltas, summaries, etc. Rather than try to fix
all of those, remove the feature until someone has interest in
completing it.
Closes: #1754
Approved by: cgwalters
Diffstat (limited to 'src/libostree/ostree-repo-private.h')
| -rw-r--r-- | src/libostree/ostree-repo-private.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/libostree/ostree-repo-private.h b/src/libostree/ostree-repo-private.h index 3cc4aba0..ad1269b3 100644 --- a/src/libostree/ostree-repo-private.h +++ b/src/libostree/ostree-repo-private.h @@ -149,8 +149,6 @@ struct OstreeRepo { dev_t device; ino_t inode; uid_t owner_uid; /* Cache of repo's owner uid */ - uid_t target_owner_uid; /* Ensure files are chowned to this uid/gid */ - gid_t target_owner_gid; guint min_free_space_percent; /* See the min-free-space-percent config option */ guint64 min_free_space_mb; /* See the min-free-space-size config option */ guint64 reserved_blocks; |