summaryrefslogtreecommitdiff
path: root/tests/test-admin-deploy-2.sh
diff options
context:
space:
mode:
authorColin Walters <walters@verbum.org>2016-01-27 11:44:10 -0500
committerColin Walters <walters@verbum.org>2016-01-27 11:44:10 -0500
commit5ebe43859d284a003e240e0cfe66b5185681e993 (patch)
tree9a50ffcbfc1688f0abeab58cfe8502b30c576d0c /tests/test-admin-deploy-2.sh
parent3d2322db7a609fb4653ce6bf6c4b96b0c315a5b7 (diff)
downloadostree-5ebe43859d284a003e240e0cfe66b5185681e993.tar.gz
tests: Use "bash strict mode"
I noticed in the static deltas tests, there were some tests that should have been under `-o pipefail` to ensure we properly propagate errors. There were a few places where we were referencing undefined variables. Overall, this is clearly a good idea IMO.
Diffstat (limited to 'tests/test-admin-deploy-2.sh')
-rwxr-xr-xtests/test-admin-deploy-2.sh3
1 files changed, 1 insertions, 2 deletions
diff --git a/tests/test-admin-deploy-2.sh b/tests/test-admin-deploy-2.sh
index d6117de0..ef6b5953 100755
--- a/tests/test-admin-deploy-2.sh
+++ b/tests/test-admin-deploy-2.sh
@@ -17,7 +17,7 @@
# Free Software Foundation, Inc., 59 Temple Place - Suite 330,
# Boston, MA 02111-1307, USA.
-set -e
+set -euo pipefail
. $(dirname $0)/libtest.sh
@@ -49,7 +49,6 @@ os_repository_new_commit "1"
bootcsum3=${bootcsum}
${CMD_PREFIX} ostree admin upgrade --os=testos
-rev=${newrev}
newrev=$(${CMD_PREFIX} ostree --repo=sysroot/ostree/repo rev-parse testos/buildmaster/x86_64-runtime)
assert_not_streq ${rev} ${newrev}
assert_not_streq ${bootcsum1} ${bootcsum2}