diff options
author | Luca BRUNO <luca.bruno@coreos.com> | 2022-01-20 10:54:30 +0000 |
---|---|---|
committer | Luca BRUNO <luca.bruno@coreos.com> | 2022-01-20 10:54:30 +0000 |
commit | da72c245f4b730d2ff41db996ec14a7f21f097e9 (patch) | |
tree | d0305e1bff5a09ce8e0150c0aba86af313a983a0 /tests/test-basic-user-only.sh | |
parent | 6230b3eeab52b132d5b7e4e164380389325db040 (diff) | |
download | ostree-da72c245f4b730d2ff41db996ec14a7f21f097e9.tar.gz |
lib/commit: reject empty metadata keys
This adds one more check to the metadata validation logic in order
to reject empty metadata keys.
Diffstat (limited to 'tests/test-basic-user-only.sh')
-rwxr-xr-x | tests/test-basic-user-only.sh | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/tests/test-basic-user-only.sh b/tests/test-basic-user-only.sh index 368abf0d..f6e8606d 100755 --- a/tests/test-basic-user-only.sh +++ b/tests/test-basic-user-only.sh @@ -23,7 +23,7 @@ set -euo pipefail mode="bare-user-only" setup_test_repository "$mode" -extra_basic_tests=6 +extra_basic_tests=7 . $(dirname $0)/basic-test.sh $CMD_PREFIX ostree --version > version.yaml @@ -58,6 +58,17 @@ cd ${test_tmpdir} rm repo-input -rf ostree_repo_init repo-input init --mode=archive rm files -rf && mkdir files +if $CMD_PREFIX ostree --repo=repo-input commit -b metadata --tree=dir=files --add-metadata-string='=FOO' 2>err.txt; then + assert_not_reached "committed an empty metadata key" +fi +assert_file_has_content err.txt "Empty metadata key" +$CMD_PREFIX ostree --repo=repo-input commit -b metadata --tree=dir=files --add-metadata-string='FOO=' +echo "ok rejected invalid metadata" + +cd ${test_tmpdir} +rm repo-input -rf +ostree_repo_init repo-input init --mode=archive +rm files -rf && mkdir files echo "a group writable file" > files/some-group-writable chmod 0664 files/some-group-writable $CMD_PREFIX ostree --repo=repo-input commit -b content-with-group-writable --tree=dir=files |