summaryrefslogtreecommitdiff
path: root/tests/test-pull-summary-caching.sh
diff options
context:
space:
mode:
authorDan Nicholson <dbn@endlessos.org>2021-04-19 11:00:20 -0600
committerDan Nicholson <dbn@endlessos.org>2021-04-19 11:09:44 -0600
commite660855796a40ad417d13cbe081bd62e56a1c6f5 (patch)
tree3a35f3f166ee0494f003e72bd3cdf7c5d108bc71 /tests/test-pull-summary-caching.sh
parent2458df446f65083df6ef4580b69839045c5985ed (diff)
downloadostree-e660855796a40ad417d13cbe081bd62e56a1c6f5.tar.gz
tests: Test without a cache directory by default
Several tests generate summaries and then expect to use the generated summary immediately. However, this can cause intermittent test failures when they inadvertantly get a cached summary file. This typically happens when the test is run on a filesystem that doesn't support user extended attributes. In that case, the caching code can only use the last modified time, which only has 1 second granularity. If tests don't carefully manage the summary modification times or the repo cache then they are likely subject to races in some test environments. This introduces an environment variable `OSTREE_SKIP_CACHE` that prevents the repo from using a cache directory. This is enabled by default in tests and disabled for tests that are a explicitly trying to test the caching behavior. Fixes: #2313 Fixes: #2351
Diffstat (limited to 'tests/test-pull-summary-caching.sh')
-rwxr-xr-xtests/test-pull-summary-caching.sh3
1 files changed, 3 insertions, 0 deletions
diff --git a/tests/test-pull-summary-caching.sh b/tests/test-pull-summary-caching.sh
index 9671199a..37c2aed6 100755
--- a/tests/test-pull-summary-caching.sh
+++ b/tests/test-pull-summary-caching.sh
@@ -31,6 +31,9 @@ if ! has_gpgme; then
exit 0
fi
+# Ensure repo caching is in use.
+unset OSTREE_SKIP_CACHE
+
COMMIT_SIGN="--gpg-homedir=${TEST_GPG_KEYHOME} --gpg-sign=${TEST_GPG_KEYID_1}"
echo "1..1"