diff options
| author | Jonathan Lebon <jlebon@redhat.com> | 2017-05-17 11:41:54 -0400 |
|---|---|---|
| committer | Atomic Bot <atomic-devel@projectatomic.io> | 2017-05-18 01:14:15 +0000 |
| commit | a8fd37b6a08540d93c99d099a32ff5c3f89a99ec (patch) | |
| tree | 08ffe9b4a9be883580d570710317283e4cd47911 /tests/test-remote-headers.sh | |
| parent | 88792f0f22a2560374d6e7e8f37e1f670f335b3f (diff) | |
| download | ostree-a8fd37b6a08540d93c99d099a32ff5c3f89a99ec.tar.gz | |
pull: complete detached meta fetch before scanning
If somehow a repo has gpg verification on but doesn't have signatures
present for the existing commit, ostree would error out if it needs to
scan the commit object (e.g. if there are no updates available).
An instance of this is currently happening in Fedora AH, in which
signatures are not shipped in the ISO due to filesystem restrictions.
Another possible scenario is if a content provider switches from not
signing commits to signing them; even if older commits are retroactively
signed, clients' local commit objects would error out if they needed
scanning.
This patch adds a check to ensure that we always attempt to fetch the
detached metadata and wait for its result (whether it exists or not)
before moving on to scan their corresponding commit objects.
See also: https://github.com/projectatomic/rpm-ostree/issues/630
Closes: #873
Approved by: cgwalters
Diffstat (limited to 'tests/test-remote-headers.sh')
| -rwxr-xr-x | tests/test-remote-headers.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/test-remote-headers.sh b/tests/test-remote-headers.sh index 6902cefb..39fbe352 100755 --- a/tests/test-remote-headers.sh +++ b/tests/test-remote-headers.sh @@ -44,9 +44,9 @@ ${CMD_PREFIX} ostree --repo=repo remote add --set=gpg-verify=false origin $(cat # Sanity check the setup, without headers the pull should fail assert_fail ${CMD_PREFIX} ostree --repo=repo pull origin main -echo "ok, setup done" +echo "ok setup done" # Now pull should succeed now ${CMD_PREFIX} ostree --repo=repo pull --http-header foo=bar --http-header baz=badger origin main -echo "ok, pull succeeded" +echo "ok pull succeeded" |