diff options
| author | Colin Walters <walters@verbum.org> | 2020-04-05 18:22:49 +0000 |
|---|---|---|
| committer | Colin Walters <walters@verbum.org> | 2020-04-05 18:49:25 +0000 |
| commit | 47539874b8e5259040a11a79b3c155e633fcae34 (patch) | |
| tree | 5771a29abe324b49d3c7dac451c9bb39fb86f70b /tests/test-signed-pull.sh | |
| parent | a16fe86b3695a997bab7814d9de63f7e09f07e93 (diff) | |
| download | ostree-47539874b8e5259040a11a79b3c155e633fcae34.tar.gz | |
pull: Update key loading function to match error style
This code wasn't written with idiomatic GError usage; it's not standard
to construct an error up front and continually append to its
message. The exit from a function is usually `return TRUE`,
with error conditions before that.
Updating it to match style reveals what I think is a bug;
we were silently ignoring failure to parse key files.
Diffstat (limited to 'tests/test-signed-pull.sh')
| -rwxr-xr-x | tests/test-signed-pull.sh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/test-signed-pull.sh b/tests/test-signed-pull.sh index f222db4f..2c677d46 100755 --- a/tests/test-signed-pull.sh +++ b/tests/test-signed-pull.sh @@ -93,6 +93,7 @@ echo "ok pull failure with incorrect keys file option" # Test with correct dummy key ${CMD_PREFIX} ostree --repo=repo config set 'remote "origin"'.verification-key "${DUMMYSIGN}" +${CMD_PREFIX} ostree --repo=repo config unset 'remote "origin"'.verification-file test_signed_pull "dummy" "" if ! has_libsodium; then |