Bug 540592 – Crash in HB_GSUB_Apply_String with Linux-Libertine fontPANGO_1_20_5PANGO_1_20_4

2008-06-29  Behdad Esfahbod  <behdad@gnome.org>

        Bug 540592 – Crash in HB_GSUB_Apply_String with Linux-Libertine font

        * pango/opentype/harfbuzz-gsub.c (GSUB_Do_String_Lookup): Fix reverse
        loops for type 8 lookups.


svn path=/trunk/; revision=2661

2 files changed, 8 insertions, 1 deletions

diff --git a/ChangeLog b/ChangeLog
index c98a6f35..77dc49eb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-06-29  Behdad Esfahbod  <behdad@gnome.org>
+
+	Bug 540592 – Crash in HB_GSUB_Apply_String with Linux-Libertine font
+
+	* pango/opentype/harfbuzz-gsub.c (GSUB_Do_String_Lookup): Fix reverse
+	loops for type 8 lookups.
+
 2008-06-26  Kristian Rietveld  <kris@imendio.com>
 
 	* configure.in: require glib trunk (for newer glib-mkenums).
diff --git a/pango/opentype/harfbuzz-gsub.c b/pango/opentype/harfbuzz-gsub.c
index 30d914ac..067122d6 100644
--- a/pango/opentype/harfbuzz-gsub.c
+++ b/pango/opentype/harfbuzz-gsub.c
@@ -4218,7 +4218,7 @@ static HB_Error  GSUB_Do_String_Lookup( HB_GSUBHeader* gsub,
 	if ( error == HB_Err_Not_Covered )
 	  buffer->in_pos--;
       }
-      while (buffer->in_pos);
+      while ((HB_Int) buffer->in_pos >= 0);
 
       return retError;