diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2021-02-28 13:19:20 -0800 |
|---|---|---|
| committer | Paul Eggert <eggert@cs.ucla.edu> | 2021-02-28 13:25:37 -0800 |
| commit | 7c7dc5ea3a8f7fca0c2696e434938c1048f9e66d (patch) | |
| tree | c5d432b155a9b00b1c7e91d0f6c69702045dedef | |
| parent | afe372f33a5dd31bcca34dc4d73e2c092447635f (diff) | |
| download | paxutils-7c7dc5ea3a8f7fca0c2696e434938c1048f9e66d.tar.gz | |
Omit ‘inline’
With today’s compilers ‘inline’ is typically not needed for
performance (at least the way GNU Tar uses it) and it gets in the
way of portability. Some compilers ignore ‘inline’ and some
inline even without ‘inline’, and when inlining is haphazard GNU
Tar can link on your GNU/Linux host but not link on Solaris.
Better to have it not link everywhere so these problems are caught
before porting.
* configure.ac: Omit AC_C_INLINE; no longer needed here.
* lib/system.h (sys_reset_uid_gid): No longer inline.
| -rw-r--r-- | configure.ac | 1 | ||||
| -rw-r--r-- | lib/system.h | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/configure.ac b/configure.ac index e2cf400..6439a21 100644 --- a/configure.ac +++ b/configure.ac @@ -29,7 +29,6 @@ gl_EARLY AC_PROG_RANLIB AC_SYS_LARGEFILE AC_ISC_POSIX -AC_C_INLINE AC_CHECK_HEADERS(fcntl.h linux/fd.h memory.h net/errno.h \ sgtty.h string.h \ diff --git a/lib/system.h b/lib/system.h index 6acefd7..92b2462 100644 --- a/lib/system.h +++ b/lib/system.h @@ -470,7 +470,7 @@ char *getenv (); # define SET_BINARY_MODE(arc) # define TTY_NAME "/dev/tty" # include <paxlib.h> -static inline char const * +static char const * sys_reset_uid_gid (void) { uid_t uid = getuid (); |