diff options
| author | Nicholas Clark <nick@ccl4.org> | 2013-09-11 11:54:42 +0200 |
|---|---|---|
| committer | Nicholas Clark <nick@ccl4.org> | 2013-09-16 11:58:45 +0200 |
| commit | 1400a53b58cffb93a158ce6193542245eaa39b7d (patch) | |
| tree | 820ea8af0a7fb648bd7e2f72a3d5d5b7f6cada71 | |
| parent | de2d3e8dce1543b8d4baf3f4f33ce6bc4fc8b7d1 (diff) | |
| download | perl-1400a53b58cffb93a158ce6193542245eaa39b7d.tar.gz | |
Eliminate the only use of VOIDFLAGS, as part of STMT_START in perl.h
STMT_START has used VOIDFLAGS as part of its conditional compilation since it
was added by commit 728e280303ae3d3b (March 1996). The code originally read:
/* Now which other defined()s do we need here ??? */
Since then it has been amended to avoid entering that definition for GCC
on Solaris. Given that all current Solaris compilers are C89 conformant,
VOIDFLAGS will always be true (actually 15), so the test is redundant.
Even back in 1996, it's possible that VOIDFLAGS was always non-zero on
SunOS, rendering the test obsolete from the start.
Spotted by Brian Fraser, and extracted from a larger patch of his.
| -rw-r--r-- | perl.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -469,7 +469,7 @@ struct op *Perl_op asm(stringify(OP_IN_REGISTER)); # define STMT_END ) # else /* Now which other defined()s do we need here ??? */ -# if (VOIDFLAGS) && (defined(sun) || defined(__sun__)) && !defined(__GNUC__) +# if (defined(sun) || defined(__sun__)) && !defined(__GNUC__) # define STMT_START if (1) # define STMT_END else (void)0 # else |