summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJarkko Hietaniemi <jhi@iki.fi>2014-07-28 22:09:34 -0400
committerJarkko Hietaniemi <jhi@iki.fi>2014-07-29 10:16:58 -0400
commit6c1246d3c25b15456c85cff0be0abc60bfb9c8f0 (patch)
tree47dbf928025cbf7a41304b35e7989b45d98ca1a3
parente05c5d0845ee6e5d8fe7218314dde23c083265cc (diff)
downloadperl-6c1246d3c25b15456c85cff0be0abc60bfb9c8f0.tar.gz
Add system to avoidables.
-rw-r--r--pod/perlclib.pod2
-rw-r--r--t/porting/libperl.t6
2 files changed, 7 insertions, 1 deletions
diff --git a/pod/perlclib.pod b/pod/perlclib.pod
index 7857ae0372..7f86f1b54e 100644
--- a/pod/perlclib.pod
+++ b/pod/perlclib.pod
@@ -224,7 +224,7 @@ everywhere by now.
PL_srand_called = TRUE; }
exit(n) my_exit(n)
- system(s) Don't. Look at pp_system or use my_popen
+ system(s) Don't. Look at pp_system or use my_popen.
getenv(s) PerlEnv_getenv(s)
setenv(s, val) my_putenv(s, val)
diff --git a/t/porting/libperl.t b/t/porting/libperl.t
index 9562556f1c..1ab1294725 100644
--- a/t/porting/libperl.t
+++ b/t/porting/libperl.t
@@ -486,9 +486,15 @@ for my $symbol (sort keys %expected) {
#
# strtol and strtoul are affected by locale.
#
+# system should not be used, use pp_system or my_popen.
+#
my %unexpected;
+for my $str (qw(system)) {
+ $unexpected{$str} = "d_$str";
+}
+
for my $stdio (qw(gets fgets tmpfile sprintf vsprintf)) {
$unexpected{$stdio} = undef; # No Configure symbol for these.
}