diff options
author | Father Chrysostomos <sprout@cpan.org> | 2011-09-17 13:23:07 -0700 |
---|---|---|
committer | Father Chrysostomos <sprout@cpan.org> | 2011-09-17 13:23:38 -0700 |
commit | 96927498a966e4c4ab367fce28456385d9e0c90e (patch) | |
tree | 95f1b9dfbb2f7b6902477bea51af7fd03d87c032 | |
parent | 5db3e519a7d788a64d2a04b7951535d385d0b9cf (diff) | |
download | perl-96927498a966e4c4ab367fce28456385d9e0c90e.tar.gz |
Correct punctuation in some POSIX error messages
Commit fa22ee54 changed some of the POSIX error messages to be more
consistent, but in doing so made many of them grammatically incorrect.
It is almost always incorrect in English to join two independent
clauses with a comma.
I don’t think it’s particularly important that error messages be gram-
matical; I just don’t want them getting worse over time. Hence, I
have not touched those that were already ungrammatical.
-rw-r--r-- | ext/POSIX/lib/POSIX.pm | 4 | ||||
-rw-r--r-- | ext/POSIX/t/unimplemented.t | 74 |
2 files changed, 39 insertions, 39 deletions
diff --git a/ext/POSIX/lib/POSIX.pm b/ext/POSIX/lib/POSIX.pm index 149ad326a5..d90794df3e 100644 --- a/ext/POSIX/lib/POSIX.pm +++ b/ext/POSIX/lib/POSIX.pm @@ -94,7 +94,7 @@ my %replacement = ( setvbuf => 'IO::Handle::setvbuf', siglongjmp => 'die', sigsetjmp => 'eval {}', - srand => \'not supplied, refer to Perl\'s srand documentation', + srand => \'not supplied; refer to Perl\'s srand documentation', sscanf => 'regular expressions', strcat => '.=', strchr => 'index()', @@ -211,7 +211,7 @@ sub AUTOLOAD { unless defined $how; croak "Unimplemented: POSIX::$func() is $$how" if ref $how; croak "Use method $how() instead of POSIX::$func()" if $how =~ /::/; - croak "Unimplemented: POSIX::$func() is C-specific, use $how instead"; + croak "Unimplemented: POSIX::$func() is C-specific: use $how instead"; } constant($func); diff --git a/ext/POSIX/t/unimplemented.t b/ext/POSIX/t/unimplemented.t index 1e38af7d4a..2d8f819831 100644 --- a/ext/POSIX/t/unimplemented.t +++ b/ext/POSIX/t/unimplemented.t @@ -9,14 +9,14 @@ plan(skip_all => "POSIX is unavailable") require POSIX; -foreach ([atexit => 'C-specific, use END {} instead'], +foreach ([atexit => 'C-specific: use END {} instead'], [atof => 'C-specific, stopped'], [atoi => 'C-specific, stopped'], [atol => 'C-specific, stopped'], [bsearch => 'not supplied'], [calloc => 'C-specific, stopped'], [clearerr => \'IO::Handle::clearerr'], - [div => 'C-specific, use /, % and int instead'], + [div => 'C-specific: use /, % and int instead'], [execl => 'C-specific, stopped'], [execle => 'C-specific, stopped'], [execlp => 'C-specific, stopped'], @@ -33,53 +33,53 @@ foreach ([atexit => 'C-specific, use END {} instead'], [fgets => \'IO::Handle::gets'], [fileno => \'IO::Handle::fileno'], [fopen => \'IO::File::open'], - [fprintf => 'C-specific, use printf instead'], - [fputc => 'C-specific, use print instead'], - [fputs => 'C-specific, use print instead'], - [fread => 'C-specific, use read instead'], + [fprintf => 'C-specific: use printf instead'], + [fputc => 'C-specific: use print instead'], + [fputs => 'C-specific: use print instead'], + [fread => 'C-specific: use read instead'], [free => 'C-specific, stopped'], - [freopen => 'C-specific, use open instead'], - [fscanf => 'C-specific, use <> and regular expressions instead'], + [freopen => 'C-specific: use open instead'], + [fscanf => 'C-specific: use <> and regular expressions instead'], [fseek => \'IO::Seekable::seek'], [fsetpos => \'IO::Seekable::setpos'], [fsync => \'IO::Handle::sync'], [ftell => \'IO::Seekable::tell'], - [fwrite => 'C-specific, use print instead'], - [labs => 'C-specific, use abs instead'], - [ldiv => 'C-specific, use /, % and int instead'], - [longjmp => 'C-specific, use die instead'], + [fwrite => 'C-specific: use print instead'], + [labs => 'C-specific: use abs instead'], + [ldiv => 'C-specific: use /, % and int instead'], + [longjmp => 'C-specific: use die instead'], [malloc => 'C-specific, stopped'], - [memchr => 'C-specific, use index() instead'], - [memcmp => 'C-specific, use eq instead'], - [memcpy => 'C-specific, use = instead'], - [memmove => 'C-specific, use = instead'], - [memset => 'C-specific, use x instead'], + [memchr => 'C-specific: use index() instead'], + [memcmp => 'C-specific: use eq instead'], + [memcpy => 'C-specific: use = instead'], + [memmove => 'C-specific: use = instead'], + [memset => 'C-specific: use x instead'], [offsetof => 'C-specific, stopped'], - [putc => 'C-specific, use print instead'], - [putchar => 'C-specific, use print instead'], - [puts => 'C-specific, use print instead'], - [qsort => 'C-specific, use sort instead'], + [putc => 'C-specific: use print instead'], + [putchar => 'C-specific: use print instead'], + [puts => 'C-specific: use print instead'], + [qsort => 'C-specific: use sort instead'], [rand => 'non-portable, use Perl\'s rand instead'], [realloc => 'C-specific, stopped'], - [scanf => 'C-specific, use <> and regular expressions instead'], + [scanf => 'C-specific: use <> and regular expressions instead'], [setbuf => \'IO::Handle::setbuf'], - [setjmp => 'C-specific, use eval {} instead'], + [setjmp => 'C-specific: use eval {} instead'], [setvbuf => \'IO::Handle::setvbuf'], - [siglongjmp => 'C-specific, use die instead'], - [sigsetjmp => 'C-specific, use eval {} instead'], - [srand => 'not supplied, refer to Perl\'s srand documentation'], - [sscanf => 'C-specific, use regular expressions instead'], - [strcat => 'C-specific, use .= instead'], - [strchr => 'C-specific, use index() instead'], - [strcmp => 'C-specific, use eq instead'], - [strcpy => 'C-specific, use = instead'], - [strcspn => 'C-specific, use regular expressions instead'], - [strlen => 'C-specific, use length instead'], - [strncat => 'C-specific, use .= instead'], - [strncmp => 'C-specific, use eq instead'], - [strncpy => 'C-specific, use = instead'], + [siglongjmp => 'C-specific: use die instead'], + [sigsetjmp => 'C-specific: use eval {} instead'], + [srand => 'not supplied; refer to Perl\'s srand documentation'], + [sscanf => 'C-specific: use regular expressions instead'], + [strcat => 'C-specific: use .= instead'], + [strchr => 'C-specific: use index() instead'], + [strcmp => 'C-specific: use eq instead'], + [strcpy => 'C-specific: use = instead'], + [strcspn => 'C-specific: use regular expressions instead'], + [strlen => 'C-specific: use length instead'], + [strncat => 'C-specific: use .= instead'], + [strncmp => 'C-specific: use eq instead'], + [strncpy => 'C-specific: use = instead'], [strpbrk => 'C-specific, stopped'], - [strrchr => 'C-specific, use rindex() instead'], + [strrchr => 'C-specific: use rindex() instead'], [strspn => 'C-specific, stopped'], [strtok => 'C-specific, stopped'], [tmpfile => \'IO::File::new_tmpfile'], |