summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFather Chrysostomos <sprout@cpan.org>2013-07-28 13:01:59 -0700
committerFather Chrysostomos <sprout@cpan.org>2013-07-28 13:01:59 -0700
commitf99a5f08f203af84430e677e25df49557c55c24f (patch)
tree0b0fb97539e198023df78a80d27591e8218711fd
parent2f222bbdd2d6da605708c3ab620ac25c62481179 (diff)
downloadperl-f99a5f08f203af84430e677e25df49557c55c24f.tar.gz
[perl #119045] Make list constant mutable again
This broke CPAN. Maybe we need to rethink this....
-rw-r--r--dist/constant/lib/constant.pm3
-rw-r--r--dist/constant/t/constant.t1
2 files changed, 3 insertions, 1 deletions
diff --git a/dist/constant/lib/constant.pm b/dist/constant/lib/constant.pm
index b8fa025180..ee5e376faa 100644
--- a/dist/constant/lib/constant.pm
+++ b/dist/constant/lib/constant.pm
@@ -162,7 +162,8 @@ sub import {
my @list = @_;
if (_CAN_PCS_FOR_ARRAY) {
Internals::SvREADONLY(@list, 1);
- Internals::SvREADONLY($list[$_], 1) for 0..$#list;
+ # Disabled for now; see perl #119045:
+ #Internals::SvREADONLY($list[$_], 1) for 0..$#list;
if ($symtab && !exists $symtab->{$name}) {
$symtab->{$name} = \@list;
$flush_mro++;
diff --git a/dist/constant/t/constant.t b/dist/constant/t/constant.t
index 129196aa60..78f21ac2c2 100644
--- a/dist/constant/t/constant.t
+++ b/dist/constant/t/constant.t
@@ -393,6 +393,7 @@ SKIP: {
# 5.19.3 and later.
SKIP: {
skip "fails under 5.19.2 and earlier", 2 if $] < 5.019003;
+ local $TODO = "disabled for now; breaks CPAN; see perl #119045";
use constant constant_list => 1..2;
for (constant_list) {
my $num = $_;