diff options
| author | Karl Williamson <public@khwilliamson.com> | 2011-09-28 15:12:35 -0600 |
|---|---|---|
| committer | Karl Williamson <public@khwilliamson.com> | 2011-10-01 09:58:10 -0600 |
| commit | ff7eba811b4638bf630692de57d5daf691c20ca7 (patch) | |
| tree | 0fab870dfbf405766b1cb3f6fe3f9682804368af | |
| parent | e3036cf4e5caf9039228e7372ba062c72f36f94a (diff) | |
| download | perl-ff7eba811b4638bf630692de57d5daf691c20ca7.tar.gz | |
handy.h: Change '(foo) ? bar : 0 to 'foo && bar'
This is clearer, and leads to better unoptimized code at least.
'bar' is a boolean
| -rw-r--r-- | handy.h | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -583,7 +583,7 @@ patched there. The file as of this writing is cpan/Devel-PPPort/parts/inc/misc || (((WIDEST_UTYPE)(c) & 0xFF) == (WIDEST_UTYPE)(c))) #ifdef EBCDIC -# define isASCII(c) (FITS_IN_8_BITS(c) ? NATIVE_TO_UNI((U8) (c)) < 128 : 0) +# define isASCII(c) (FITS_IN_8_BITS(c) && (NATIVE_TO_UNI((U8) (c)) < 128)) #else # define isASCII(c) ((WIDEST_UTYPE)(c) < 128) #endif @@ -679,7 +679,7 @@ EXTCONST U32 PL_charclass[]; # define isALNUMC_A(c) (isALPHA_A(c) || isDIGIT_A(c)) # define isALPHA_A(c) (isUPPER_A(c) || isLOWER_A(c)) # define isBLANK_A(c) ((c) == ' ' || (c) == '\t') -# define isCNTRL_A(c) (FITS_IN_8_BITS(c) ? ((U8) (c) < ' ' || (c) == 127) : 0) +# define isCNTRL_A(c) (FITS_IN_8_BITS(c) && ((U8) (c) < ' ' || (c) == 127)) # define isDIGIT_A(c) ((c) >= '0' && (c) <= '9') # define isGRAPH_A(c) (isWORDCHAR_A(c) || isPUNCT_A(c)) # define isIDFIRST_A(c) (isALPHA_A(c) || (c) == '_') @@ -879,7 +879,7 @@ EXTCONST U32 PL_charclass[]; #define isLOWER_uni(c) generic_uni(isLOWER, is_uni_lower, c) #define isASCII_uni(c) isASCII(c) /* All controls are in Latin1 */ -#define isCNTRL_uni(c) ((c) < 256 ? isCNTRL_L1(c) : 0) +#define isCNTRL_uni(c) ((c) < 256 && isCNTRL_L1(c)) #define isGRAPH_uni(c) generic_uni(isGRAPH, is_uni_graph, c) #define isPRINT_uni(c) generic_uni(isPRINT, is_uni_print, c) #define isPUNCT_uni(c) generic_uni(isPUNCT, is_uni_punct, c) |