diff options
| author | Nicholas Clark <nick@ccl4.org> | 2012-04-09 09:25:09 +0200 |
|---|---|---|
| committer | Nicholas Clark <nick@ccl4.org> | 2013-05-28 09:19:28 +0200 |
| commit | a84ce349a5d624d744483112ba9c1b191f6b9158 (patch) | |
| tree | 5ac95c36ad123e249fca06b4a0da2ad1832e403d /Porting/bisect.pl | |
| parent | 40c9485684ea62c3628bbee3f8b62187d00780c7 (diff) | |
| download | perl-a84ce349a5d624d744483112ba9c1b191f6b9158.tar.gz | |
When testing the end version, bisect.pl should treat a 'skip' as fatal.
git bisect uses exit code 125 to signal a skip. Previously bisect.pl would
treat 125 just like every other non-zero exit code, assume that it meant
'fail', and if 'fail' was expected for the end version then it would start
the bisect run as normal. Which isn't useful, as it means that there's a
problem with the user's test case.
Diffstat (limited to 'Porting/bisect.pl')
| -rwxr-xr-x | Porting/bisect.pl | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Porting/bisect.pl b/Porting/bisect.pl index 96d7b8c5af..c52c740770 100755 --- a/Porting/bisect.pl +++ b/Porting/bisect.pl @@ -135,6 +135,8 @@ if ($git_version ge v1.6.6) { system "git checkout $end" and die; my $ret = system $^X, $runner, @ARGV; die "Runner returned $ret for end revision" unless $ret; +die "Runner returned $ret for end revision, which is a skip" + if $ret == 125 * 256; if (defined $start) { system "git checkout $start" and die; |