diff options
| author | Zefram <zefram@fysh.org> | 2018-03-30 23:07:36 +0100 |
|---|---|---|
| committer | Zefram <zefram@fysh.org> | 2018-03-30 23:07:36 +0100 |
| commit | a77eff3cee8f0785758b235ecf8fc42a4f945e08 (patch) | |
| tree | 766ffaecdb89aa5ee0c538f355f056d06d15b1db /dist/Carp | |
| parent | 520aba9828daf9fa3303b933f477053b4742dc90 (diff) | |
| download | perl-a77eff3cee8f0785758b235ecf8fc42a4f945e08.tar.gz | |
delete unreliable test of Carp crash avoidance
rt52610_crash.t was introduced by commit
4764858cb80e76fdba33cc1b3be8fcdef26df754, and is predicated on
the mythical effectiveness of that commit's code change in avoiding
stack-not-refcounted crashes, an effectiveness also expressed in that
commit's very inaccurate commit message. In fact the code change will
avoid *some* crashes, but cannot guarantee to avoid crashing in any
particular situation of the kind that it targets. It is therefore not
possible to have a test for it avoiding a stack-not-refcounted crash,
with any expectation that the test would reliably pass or even reliably
avoid crashing. rt52610_crash.t must therefore be deleted.
Diffstat (limited to 'dist/Carp')
| -rw-r--r-- | dist/Carp/lib/Carp.pm | 2 | ||||
| -rw-r--r-- | dist/Carp/lib/Carp/Heavy.pm | 2 | ||||
| -rw-r--r-- | dist/Carp/t/rt52610_crash.t | 25 |
3 files changed, 2 insertions, 27 deletions
diff --git a/dist/Carp/lib/Carp.pm b/dist/Carp/lib/Carp.pm index 97f6604a17..109b7fec77 100644 --- a/dist/Carp/lib/Carp.pm +++ b/dist/Carp/lib/Carp.pm @@ -211,7 +211,7 @@ BEGIN { } -our $VERSION = '1.49'; +our $VERSION = '1.50'; $VERSION =~ tr/_//d; our $MaxEvalLen = 0; diff --git a/dist/Carp/lib/Carp/Heavy.pm b/dist/Carp/lib/Carp/Heavy.pm index e2b72920a3..a9b803c76a 100644 --- a/dist/Carp/lib/Carp/Heavy.pm +++ b/dist/Carp/lib/Carp/Heavy.pm @@ -2,7 +2,7 @@ package Carp::Heavy; use Carp (); -our $VERSION = '1.49'; +our $VERSION = '1.50'; $VERSION =~ tr/_//d; # Carp::Heavy was merged into Carp in version 1.12. Any mismatched versions diff --git a/dist/Carp/t/rt52610_crash.t b/dist/Carp/t/rt52610_crash.t deleted file mode 100644 index faa19cb890..0000000000 --- a/dist/Carp/t/rt52610_crash.t +++ /dev/null @@ -1,25 +0,0 @@ -use warnings; -use strict; - -use Test::More tests => 1; - -use Carp (); - -sub do_carp { - Carp::longmess; -} - -sub call_with_args { - my ($arg_hash, $func) = @_; - $func->(@{$arg_hash->{'args'}}); -} - -my $msg; -my $h = {}; -my $arg_hash = {'args' => [undef]}; -call_with_args($arg_hash, sub { - $arg_hash->{'args'} = []; - $msg = do_carp(sub { $h; }); -}); - -like $msg, qr/^ at.+\b(?i:rt52610_crash\.t) line \d+\.\n\tmain::__ANON__\(.*\) called at.+\b(?i:rt52610_crash\.t) line \d+\n\tmain::call_with_args\(HASH\(0x[[:xdigit:]]+\), CODE\(0x[[:xdigit:]]+\)\) called at.+\b(?i:rt52610_crash\.t) line \d+$/; |