diff options
author | Nicolas R <atoomic@cpan.org> | 2017-09-12 13:20:25 -0600 |
---|---|---|
committer | Todd Rinaldo <toddr@cpan.org> | 2017-11-11 01:07:18 -0600 |
commit | 1a58b39af83e11fcbeef7ae4cd90c565b1f6b8cb (patch) | |
tree | 542b8e3ec768e2b3a533354d694d53c6c161e8e5 /dist/I18N-LangTags | |
parent | 33394adc9b131beee7dbbaf29bc7e8e02900f654 (diff) | |
download | perl-1a58b39af83e11fcbeef7ae4cd90c565b1f6b8cb.tar.gz |
Replace multiple 'use vars' by 'our' in dist
Using vars pragma is discouraged and has been superseded
by 'our' declarations available in Perl v5.6.0 or later.
Additionally using 'vars' pragma increase the memory consumption of a
program by about 700 kB for no good reason.
This commit is about replacing the usage of 'vars' pragma
by 'our' in blead where it makes sense. ( leaving 'cpan' directory
outside of the scope )
-- using vars
perl -e 'use vars qw(@ISA $AUTOLOAD $VERSION); print qx{grep RSS /proc/$$/status} '
VmRSS: 2588 kB
-- using our instead
perl -e 'our (@ISA, $AUTOLOAD, $VERSION); print qx{grep RSS /proc/$$/status} '
VmRSS: 1864 kB
Diffstat (limited to 'dist/I18N-LangTags')
-rw-r--r-- | dist/I18N-LangTags/lib/I18N/LangTags.pm | 12 | ||||
-rw-r--r-- | dist/I18N-LangTags/lib/I18N/LangTags/Detect.pm | 8 | ||||
-rw-r--r-- | dist/I18N-LangTags/lib/I18N/LangTags/List.pm | 4 |
3 files changed, 12 insertions, 12 deletions
diff --git a/dist/I18N-LangTags/lib/I18N/LangTags.pm b/dist/I18N-LangTags/lib/I18N/LangTags.pm index c4d9ceab3d..3358d60274 100644 --- a/dist/I18N-LangTags/lib/I18N/LangTags.pm +++ b/dist/I18N-LangTags/lib/I18N/LangTags.pm @@ -5,11 +5,10 @@ require 5.000; package I18N::LangTags; use strict; -use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $VERSION %Panic); require Exporter; -@ISA = qw(Exporter); -@EXPORT = qw(); -@EXPORT_OK = qw(is_language_tag same_language_tag +our @ISA = qw(Exporter); +our @EXPORT = qw(); +our @EXPORT_OK = qw(is_language_tag same_language_tag extract_language_tags super_languages similarity_language_tag is_dialect_of locale2language_tag alternate_language_tags @@ -17,9 +16,10 @@ require Exporter; implicate_supers implicate_supers_strictly ); -%EXPORT_TAGS = ('ALL' => \@EXPORT_OK); +our %EXPORT_TAGS = ('ALL' => \@EXPORT_OK); -$VERSION = "0.42"; +our $VERSION = "0.43"; +our %Panic; sub uniq { my %seen; return grep(!($seen{$_}++), @_); } # a util function diff --git a/dist/I18N-LangTags/lib/I18N/LangTags/Detect.pm b/dist/I18N-LangTags/lib/I18N/LangTags/Detect.pm index a0f3d1db8d..16b91db336 100644 --- a/dist/I18N-LangTags/lib/I18N/LangTags/Detect.pm +++ b/dist/I18N-LangTags/lib/I18N/LangTags/Detect.pm @@ -5,14 +5,14 @@ require 5; package I18N::LangTags::Detect; use strict; -use vars qw( @ISA $VERSION $MATCH_SUPERS $USING_LANGUAGE_TAGS - $USE_LITERALS $MATCH_SUPERS_TIGHTLY); +our ( $MATCH_SUPERS, $USING_LANGUAGE_TAGS, + $USE_LITERALS, $MATCH_SUPERS_TIGHTLY); BEGIN { unless(defined &DEBUG) { *DEBUG = sub () {0} } } # define the constant 'DEBUG' at compile-time -$VERSION = "1.06"; -@ISA = (); +our $VERSION = "1.07"; +our @ISA = (); use I18N::LangTags qw(alternate_language_tags locale2language_tag); sub _uniq { my %seen; return grep(!($seen{$_}++), @_); } diff --git a/dist/I18N-LangTags/lib/I18N/LangTags/List.pm b/dist/I18N-LangTags/lib/I18N/LangTags/List.pm index 786d7b89bb..5eef8eebaf 100644 --- a/dist/I18N-LangTags/lib/I18N/LangTags/List.pm +++ b/dist/I18N-LangTags/lib/I18N/LangTags/List.pm @@ -3,8 +3,8 @@ require 5; package I18N::LangTags::List; # Time-stamp: "2004-10-06 23:26:21 ADT" use strict; -use vars qw(%Name %Is_Disrec $Debug $VERSION); -$VERSION = '0.39'; +our (%Name, %Is_Disrec, $Debug); +our $VERSION = '0.40'; # POD at the end. #---------------------------------------------------------------------- |