diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2014-09-17 21:16:58 -0800 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2014-11-02 18:23:43 -0800 |
| commit | 96d7c88819733eaaba892177a967d9e898b2b924 (patch) | |
| tree | dcc519ccc95d8fdc5e1c912e4b704da38d26f8a0 /embed.h | |
| parent | f4725fad1a6349bcfadca13ee4398f61799a29d0 (diff) | |
| download | perl-96d7c88819733eaaba892177a967d9e898b2b924.tar.gz | |
[perl #57512] Warnings for implicitly closed handles
If the implicit close() fails, warn about it, mentioning $! in the
message. This is a default warning in the io category.
We do this in two spots, sv_clear and gp_free. While sv_clear would
be sufficient to get the warning emitted, the warning won’t contain
the name of the handle when called from there, because lone IO thing-
ies are nameless. Doing it also when a GV’s glob pointer is freed--as
long as the IO thingy in there has a reference count of 1--allows the
name to be included in the message, because we still have the glob,
which is where the name is stored.
The result:
$ ./miniperl -Ilib -e 'open fh, ">/Volumes/Disk Image/foo"; print fh "x"x1000, "\n" for 1..50; undef *fh'
Warning: unable to close filehandle fh properly: No space left on device at -e line 1.
Diffstat (limited to 'embed.h')
| -rw-r--r-- | embed.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1185,7 +1185,7 @@ #define init_constants() Perl_init_constants(aTHX) #define init_debugger() Perl_init_debugger(aTHX) #define invert(a) Perl_invert(aTHX_ a) -#define io_close(a,b) Perl_io_close(aTHX_ a,b) +#define io_close(a,b,c,d) Perl_io_close(aTHX_ a,b,c,d) #define isinfnansv(a) Perl_isinfnansv(aTHX_ a) #define jmaybe(a) Perl_jmaybe(aTHX_ a) #define keyword(a,b,c) Perl_keyword(aTHX_ a,b,c) |