summaryrefslogtreecommitdiff
path: root/ext/Devel-Peek
diff options
context:
space:
mode:
authorJames E Keenan <jkeenan@cpan.org>2019-01-20 15:48:19 -0500
committerJames E Keenan <jkeenan@cpan.org>2019-01-20 15:48:19 -0500
commit187a41620b03725e88921c72501b2e72a66ed313 (patch)
tree7b808787a4fba8804b9ec370a9ffe1db57410a89 /ext/Devel-Peek
parent682600244fff4af0e080e503dac9bdd3778e179c (diff)
downloadperl-187a41620b03725e88921c72501b2e72a66ed313.tar.gz
Provide defined value for $TODO only where test should not run.
Some tests should not be run on older perls. To indicate that, provide an undef rather than a defined but false value. This reflects Test::Builder synch with CPAN for upstream bug fix: https://github.com/Test-More/test-more/commit/9c269ff6e2b8a7be223ef1df7a254a09ec4dad2d Note that these should really be SKIPs rather than TODOs (but we can handle that later).
Diffstat (limited to 'ext/Devel-Peek')
-rw-r--r--ext/Devel-Peek/t/Peek.t19
1 files changed, 9 insertions, 10 deletions
diff --git a/ext/Devel-Peek/t/Peek.t b/ext/Devel-Peek/t/Peek.t
index 2c0c849cf6..f3f781ac6b 100644
--- a/ext/Devel-Peek/t/Peek.t
+++ b/ext/Devel-Peek/t/Peek.t
@@ -286,8 +286,7 @@ do_test('reference to hash',
MAX = 7
Elt "123" HASH = $ADDR' . $c_pattern,
'',
- $] < 5.015
- && 'The hash iterator used in dump.c sets the OOK flag');
+ ($] < 5.015) ? 'The hash iterator used in dump.c sets the OOK flag' : undef);
do_test('reference to anon sub with empty prototype',
sub(){@_},
@@ -457,7 +456,7 @@ do_test('reference to blessed hash',
FILL = 0
MAX = 7', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
do_test('typeglob',
@@ -535,7 +534,7 @@ do_test('reference to hash containing Unicode',
COW_REFCNT = 1 # $] < 5.019007
', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
} else {
do_test('reference to hash containing Unicode',
@@ -562,7 +561,7 @@ do_test('reference to hash containing Unicode',
COW_REFCNT = 1 # $] < 5.019007
', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
}
@@ -767,7 +766,7 @@ do_test('blessing to a class with embedded NUL characters',
FILL = 0
MAX = 7', '',
$] >= 5.015
- ? 0
+ ? undef
: 'The hash iterator used in dump.c sets the OOK flag');
do_test('ENAME on a stash',
@@ -928,7 +927,7 @@ do_test('small hash after keys and scalar',
# Dump with arrays, hashes, and operator return values
@array = 1..3;
-do_test('Dump @array', '@array', <<'ARRAY', '', '', 1);
+do_test('Dump @array', '@array', <<'ARRAY', '', undef, 1);
SV = PVAV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(\)
@@ -953,7 +952,7 @@ SV = PVAV\($ADDR\) at $ADDR
IV = 3
ARRAY
-do_test('Dump @array,1', '@array,1', <<'ARRAY', '', '', 1);
+do_test('Dump @array,1', '@array,1', <<'ARRAY', '', undef, 1);
SV = PVAV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(\)
@@ -969,7 +968,7 @@ SV = PVAV\($ADDR\) at $ADDR
ARRAY
%hash = 1..2;
-do_test('Dump %hash', '%hash', <<'HASH', '', '', 1);
+do_test('Dump %hash', '%hash', <<'HASH', '', undef, 1);
SV = PVHV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(SHAREKEYS\)
@@ -986,7 +985,7 @@ SV = PVHV\($ADDR\) at $ADDR
HASH
$_ = "hello";
-do_test('rvalue substr', 'substr $_, 1, 2', <<'SUBSTR', '', '', 1);
+do_test('rvalue substr', 'substr $_, 1, 2', <<'SUBSTR', '', undef, 1);
SV = PV\($ADDR\) at $ADDR
REFCNT = 1
FLAGS = \(PADTMP,POK,pPOK\)