embed.pl - the 's', 'S', 'i' and 'I' flags are mutually exclusive

We had a bug where we processed the first one in the flags definition. Sorting
the flags or rearranging them changes the output, which shouldn't happen.

This also fixes the handling and specification of PerlEnv_putenv(), which was
marked "si" when it should have been marked "i". This required changing its
implementation from a Perl_ prefix to a S_ prefix and regenerating.

I have run embed.pl in a loop with a local patch to shuffle the flags to see
if there were any other order dependencies. No output files changed so I
assume with this patch we are free of such bugs.

1 files changed, 1 insertions, 1 deletions

diff --git a/inline.h b/inline.h
index 06a773d2c3..fce84b4d96 100644
--- a/inline.h
+++ b/inline.h
@@ -287,7 +287,7 @@ S_strip_spaces(pTHX_ const char * orig, STRLEN * const len)
 /* Otherwise this function is implemented as macros in iperlsys.h */
 
 PERL_STATIC_INLINE bool
-Perl_PerlEnv_putenv(pTHX_ char * str)
+S_PerlEnv_putenv(pTHX_ char * str)
 {
     PERL_ARGS_ASSERT_PERLENV_PUTENV;